docs(rfc): accept RFC 0019 — storage-backend selection

[jensholdgaard]

What

Promote RFC 0019 (storage-backend selection) green → accepted (terminal) — the maintainer sign-off.

RFC 0019 has been green on main since #301: the server chooses local vs S3 for the data store (the WAL stays local by design), with all eight §5 criteria backed by passing tests —

• .1/.6/.7 unit tests: build_store_config, credential scrub, local-default regression
• .2/.3/.4/.5 localstack S3 integration: WAL-stays-local, ingest→query round-trip on S3, the compactor's conditional-PUT manifest swap, cross-tenant isolation
• .8 explicit OURIOS_S3_* credentials (docs(rfc): explicit OURIOS_S3_* credential env keys (RFC 0019 §3.4 + RFC0019.8) #306/feat(server): explicit OURIOS_S3_* S3 credentials (RFC 0019 §9 / RFC0019.8) #307 amendment)

No validated stage applies (backend selection is server wiring, not a thesis-gate benchmark), so acceptance follows green directly — the RFC 0001 / 0008 precedent. §9 records the sign-off.

Docs-only. mdbook build clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01X467Druw4cQeEPVp52DTG3

[coderabbitai]

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 907de506-4c84-49c0-bf21-5b98dc98120c

📥 Commits

Reviewing files that changed from the base of the PR and between 788d84d and dd107b2.

📒 Files selected for processing (1)

• docs/rfcs/0019-storage-backend-selection.md

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0019-accept

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Promotes RFC 0019 (“storage-backend selection — wiring the server to choose local vs S3”) from green to terminal accepted, recording maintainer sign-off in the RFC’s amendment history.

Changes:

• Update RFC 0019 front-matter status: green → status: accepted.
• Add an amendment-history entry documenting acceptance/sign-off and rationale for skipping validated.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.