test(rfc0030): red — all nine §5 stubs land, status specified→red

[jensholdgaard]

Maintainer signed off on RFC 0030 §5 — this is the red gate (the RFC 0029 #421 pattern verbatim).

Nine #[ignore]d todo!() stubs, split per the RFC's §6 ownership: RFC0030.1/.2/.4/.5/.6/.7/.9 in ourios-ingester's tests/it harness, RFC0030.3/.8 in ourios-server's. Each stub's ignore reason names the green slice that discharges it (config / acceptor / mTLS / reload / querier / served). RFC frontmatter flips specified→red.

Verified: cargo fmt --check, cargo clippy --all-targets --all-features -- -D warnings (exit 0), cargo nextest run on both harnesses (93 passed, 17 skipped — the new stubs are in the skipped set; nextest list --run-ignored all -E 'test(rfc0030)' shows exactly the nine).

Green slices follow as separate PRs: config → acceptor → mTLS → reload → querier → served.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests

  • Added new integration test coverage placeholders for TLS and mTLS scenarios across the server and ingester components.
  • Expanded the test harness to include the new TLS-focused suites.

• Documentation

  • Updated the RFC 0030 document status to reflect its current review state.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f6d9b29-37fd-4b92-a233-dd5bd567a132

📥 Commits

Reviewing files that changed from the base of the PR and between dc64aff and 84872f5.

📒 Files selected for processing (5)

• crates/ourios-ingester/tests/it/main.rs
• crates/ourios-ingester/tests/it/rfc0030_tls.rs
• crates/ourios-server/tests/it/main.rs
• crates/ourios-server/tests/it/rfc0030_tls.rs
• docs/rfcs/0030-tls-mtls-listeners.md

---

📝 Walkthrough

Walkthrough

Adds a new rfc0030_tls integration test module to both the ourios-ingester and ourios-server test harnesses, containing ignored stub tests with todo!() placeholders for TLS/mTLS listener scenarios. Also updates RFC 0030's front-matter status from "specified" to "red".

Changes

RFC0030 TLS Test Stubs

Layer / File(s)	Summary
Ingester RFC0030 TLS stub tests crates/ourios-ingester/tests/it/main.rs, crates/ourios-ingester/tests/it/rfc0030_tls.rs	Registers the new module and adds seven ignored, todo!()-based stub tests covering handshake gating, startup validation, certificate reload, plaintext-auth warnings, and min_version enforcement.
Server RFC0030 TLS stub tests crates/ourios-server/tests/it/main.rs, crates/ourios-server/tests/it/rfc0030_tls.rs	Registers the new module and adds two ignored stub tests for querier/MCP-over-TLS and served end-to-end TLS scenarios.
RFC 0030 status update docs/rfcs/0030-tls-mtls-listeners.md	Changes the RFC's front-matter status field from "specified" to "red".

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• jensholdgaard/ourios#399: Both PRs modify crates/ourios-ingester/tests/it/main.rs by adding mod declarations to the consolidated integration-test harness.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	It covers the PR’s purpose and verification, but it omits the required Summary/Related/Checklist template sections and checkbox list.	Reformat the body to match the template with explicit Summary, Related, and Checklist headings, including the required checkbox items and RFC link.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the RFC 0030 red-gate test stubs and status change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0030-red

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Moves RFC 0030 (TLS/mTLS listeners) into the red gate by flipping the RFC frontmatter status and landing the full set of nine #[ignore]d §5 scenario stubs across the two existing integration-test harnesses, matching the established “red gate = ignored todo!() stubs” workflow.

Changes:

• Update RFC 0030 frontmatter status from specified → red.
• Add RFC0030 §5 integration-test stubs: 7 scenarios in ourios-ingester harness and 2 scenarios in ourios-server harness.
• Wire the new RFC0030 test modules into each harness main.rs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
docs/rfcs/0030-tls-mtls-listeners.md	Flip RFC status to red in frontmatter to reflect red gate.
crates/ourios-server/tests/it/rfc0030_tls.rs	Add ignored todo!() stubs for RFC0030.3 and RFC0030.8 (querier/MCP TLS + served end-to-end).
crates/ourios-server/tests/it/main.rs	Register the new rfc0030_tls test module in the server IT harness.
crates/ourios-ingester/tests/it/rfc0030_tls.rs	Add ignored todo!() stubs for the 7 receiver-side RFC0030 scenarios.
crates/ourios-ingester/tests/it/main.rs	Register the new rfc0030_tls test module in the ingester IT harness.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.