test(miner): rfc 0028 slice 2e — 3 test binaries fold into one harness - #404
Merged
Conversation
Pure moves (incl. the proptest-regressions sidecar) + the harness main.rs; the weekly deep-run's miner line retargets in the same commit (RFC0028.5). Four binaries stay dedicated (RFC0028.2): each installs the process-global OTel meter provider for one telemetry arm — reasons in tests/README.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds a consolidated integration-test harness entrypoint ( ChangesTest harness consolidation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates three ourios-miner integration-test binaries into a single tests/it/ harness (per RFC 0028 slice 2e), while keeping the process-global OTel meter-provider tests as dedicated binaries, and retargets the RFC 0024 deep-run workflow to the new harness invocation.
Changes:
- Add
crates/ourios-miner/tests/it/consolidated harness (main.rs) and move RFC0004/RFC0017/RFC0024 test modules into it. - Add
crates/ourios-miner/tests/README.mddocumenting which integration tests must remain harness-exempt and why. - Update
.github/workflows/rfc0024-deep-run.ymlto run miner’s RFC0024 properties via--test it rfc0024_properties.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/ourios-miner/tests/README.md | Documents the new miner integration-test layout and the harness-exempt binaries. |
| crates/ourios-miner/tests/it/main.rs | Introduces the consolidated miner integration-test harness and wires in moved modules. |
| crates/ourios-miner/tests/it/rfc0004_configuration_policy.rs | Moves RFC0004 configuration-policy integration tests into the harness (verbatim). |
| crates/ourios-miner/tests/it/rfc0017_template_created.rs | Moves RFC0017 “template_created” audit event test into the harness (verbatim). |
| crates/ourios-miner/tests/it/rfc0024_properties.rs | Moves miner-owned RFC0024 property tests into the harness (verbatim). |
| crates/ourios-miner/tests/it/rfc0024_properties.proptest-regressions | Relocates the proptest regression persistence sidecar alongside the moved test module. |
| .github/workflows/rfc0024-deep-run.yml | Retargets the deep-run job to execute the miner RFC0024 properties through the it harness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RFC 0028 slice 2e (the last of slice 2) — the miner's 7 integration-test binaries become 5:
rfc0004_configuration_policy,rfc0017_template_created, andrfc0024_properties(with its proptest-regressions sidecar, resolved source-relative) fold into thetests/it/harness. The weekly deep-run's miner line retargets to--test it rfc0024_propertiesin the same commit (RFC0028.5). No test body changed.RFC0028.2 — harness-exempt binaries
Four stay dedicated, documented in
tests/README.md:invariants.rs(§6.5 param-overflow metrics arm),hazards.rs(per-service overflow-rate alert arm),rfc0023_bounded_memory.rs(template-ceiling/eviction metrics arm),rfc_internal.rs(confidence-gauge quantile arm) — each installs the process-global OTel meter provider (init_in_memory), and two installers in one process race.RFC0028.1 — inventory proof
cargo test -p ourios-miner -- --list: 206 tests before, 206 after; leaf-name sets identical after stripping module-path prefixes (snapshots below).Indicative timing (not the RFC0028.3 gate)
Same machine, warm workspace:
touch crates/ourios-miner/src/lib.rs && cargo test -p ourios-miner --no-run— 21.8 s before, 17.7 s after (the smallest win, as expected — 5 binaries remain and the miner links lightly).Slice 2 complete. Consolidated across #399/#400/#401/#402/#403/this: ingester 31→5, querier 19→1, parquet 17→1, wal 11→1, server 9→2, miner 7→5 — 94 binaries → 15. The authoritative RFC0028.3 probe re-run follows this merge, recorded in epic #382.
Invariants / hazards
CLAUDE.md §6.2 (tests are specifications): nothing weakened or deleted.
Pre inventory (206)
Post inventory (206)
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation