test(rfc0025): red — all five §5 stubs land, status specified → red

[jensholdgaard]

The RFC 0025 red gate: five #[ignore]d stubs across the three owning crates, each naming its green slice. Status specified → red; implementation may begin.

Green slices planned: (a) schema — body_kind ordinal 2 + reader + miner lossy-flag change + RFC 0024 P1 arm flip (.1/.2), (b) read path — absent-vs-empty rendering (.3), (c) sink quarantine + telemetry (.4/.5).

Verified: three stub binaries compile with 2+1+2 ignored; fmt clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation

  • Updated the RFC status to reflect its current implementation phase.

• Tests

  • Added new ignored test stubs covering absent-body handling, rendering differences between empty and missing content, and quarantine-related scenarios.
  • These tests document the expected behavior for upcoming work while keeping the current test suite passing.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e36a298e-3f06-4a2e-8a5f-06cc5c2b0ac1

📥 Commits

Reviewing files that changed from the base of the PR and between 8449dcc and d56fdbd.

📒 Files selected for processing (4)

• crates/ourios-ingester/tests/rfc0025_quarantine.rs
• crates/ourios-parquet/tests/rfc0025_absent_body.rs
• crates/ourios-querier/tests/rfc0025_rendering.rs
• docs/rfcs/0025-absent-body-representation.md

---

📝 Walkthrough

Walkthrough

This PR adds ignored Rust test stubs across three crates (ourios-ingester, ourios-parquet, ourios-querier) for RFC 0025 scenarios covering quarantine behavior, absent-body round-trips, and rendering distinctions. Each stub uses todo! with descriptive text and remains skipped via #[ignore]. The RFC document's status field is also updated from "specified" to "red".

Changes

RFC 0025 Test Stubs and Status Update

Layer / File(s)	Summary
Ingester quarantine stubs crates/ourios-ingester/tests/rfc0025_quarantine.rs	Adds two ignored tests (rfc0025_4_sink_quarantines_instead_of_wedging, rfc0025_5_quarantine_telemetry) with todo! bodies describing expected sink quarantine persistence, successful flush, and flush-error telemetry counter behavior.
Storage absent-body round-trip stubs crates/ourios-parquet/tests/rfc0025_absent_body.rs	Adds two ignored tests (rfc0025_1_absent_bodies_round_trip, rfc0025_2_old_files_unaffected) with todo! bodies describing absent-body NULL round-trip parity and amended-reader fixture compatibility.
Rendering distinction stub crates/ourios-querier/tests/rfc0025_rendering.rs	Adds one ignored test (rfc0025_3_rendering_distinguishes_absent_from_empty) with a todo! body describing expected distinction between empty and absent bodies during rendering.
RFC status update docs/rfcs/0025-absent-body-representation.md	Updates the front-matter status field from specified to red.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the RFC 0025 red-gate test stubs and the status change.
Description check	✅ Passed	It covers the PR goal, planned slices, and verification, but it misses the template's Related section and explicit checklist items.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0025-red

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Advances RFC 0025 to the red gate by marking the RFC status as red and adding five compiling, #[ignore]d red-test stubs (one per §5 scenario) across the owning crates, so implementation can begin while keeping default CI green.

Changes:

• Flip RFC 0025 frontmatter status from specified → red.
• Add five #[ignore]d todo!() acceptance-test stubs for RFC0025.1–.5 across ourios-parquet, ourios-querier, and ourios-ingester.
• Cross-link scenario placement among the three crates’ test modules for greppability.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
docs/rfcs/0025-absent-body-representation.md	Updates RFC status to red to reflect the new red-test stubs landing.
crates/ourios-querier/tests/rfc0025_rendering.rs	Adds the ignored red stub for RFC0025.3 (rendering absent vs empty).
crates/ourios-parquet/tests/rfc0025_absent_body.rs	Adds ignored red stubs for RFC0025.1–.2 (round-trip + old-file parity).
crates/ourios-ingester/tests/rfc0025_quarantine.rs	Adds ignored red stubs for RFC0025.4–.5 (quarantine behavior + telemetry).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.