test(rfc0026): red — all seven §5 stubs land, status specified → red

[jensholdgaard]

The RFC 0026 red gate: eight #[ignore]d stubs across the two owning crates (RFC0026.5 splits into ingest + query halves), each naming the green slice that discharges it. Status specified → red; implementation may begin per the lifecycle.

Green slices planned: (a) config token store (RFC0026.1), (b) ingest interceptors + tenant binding (.2/.3/.5-ingest), (c) query gate (.4/.5-query/.6), (d) telemetry/audit (.7).

Verified: both stub binaries compile with 4+4 ignored; cargo fmt and clippy clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added RFC 0026 authentication coverage for server and ingester scenarios, including bearer handling, tenant binding, wildcard token behavior, and rejection/audit expectations.
• Tests
  • Introduced several new, currently ignored test stubs to capture the expected authentication and telemetry behavior.
• Documentation
  • Expanded RFC 0025 acceptance criteria with clearer scenario definitions.
  • Updated RFC 0026 status metadata.

[coderabbitai]

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9aca342d-95ac-44d9-b34d-32c05724fac4

📥 Commits

Reviewing files that changed from the base of the PR and between dd97cc9 and 0d1eb53.

📒 Files selected for processing (3)

• crates/ourios-ingester/tests/rfc0026_auth.rs
• crates/ourios-server/tests/rfc0026_auth.rs
• docs/rfcs/0026-authentication-tenant-binding.md

📝 Walkthrough

Walkthrough

This PR adds ignored stub test files for RFC0026 authentication and tenant binding scenarios in both ourios-ingester and ourios-server crates, each containing todo! placeholders. It also expands RFC0025's acceptance criteria documentation and changes RFC0026's status field to "red".

Changes

RFC0026 authentication test stubs

Layer / File(s)	Summary
Ingester-side RFC0026 test stubs crates/ourios-ingester/tests/rfc0026_auth.rs	Adds module documentation and four ignored stub tests (rfc0026_2_ingest_authentication, rfc0026_3_ingest_tenant_binding, rfc0026_5_wildcard_binding_ingest, rfc0026_7_rejection_telemetry_and_audit), each with todo! describing expected rejection/audit/telemetry semantics.
Server-side RFC0026 test stubs crates/ourios-server/tests/rfc0026_auth.rs	Adds four ignored stub tests (rfc0026_1_token_store_configuration, rfc0026_4_query_status_contract, rfc0026_5_wildcard_binding_query, rfc0026_6_open_mode_parity) with todo! placeholders documenting expected server-side auth behavior.

RFC documentation updates

Layer / File(s)	Summary
RFC0025 acceptance criteria and RFC0026 status docs/rfcs/0025-absent-body-representation.md, docs/rfcs/0026-authentication-tenant-binding.md	Expands RFC0025's acceptance criteria with five detailed scenarios and changes RFC0026's status field from "specified" to "red".

Estimated code review effort: 2 (Simple) | ~10 minutes

Related PRs: None identified from the provided context.

Suggested labels: documentation, tests, rfc

Suggested reviewers: None identified from the provided context.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the PR’s main change: adding the RFC0026 red-gate stubs and changing status from specified to red.
Description check	✅ Passed	The description covers the PR purpose and validation, but it does not follow the template’s explicit Summary/Related/Checklist structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0026-red

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR advances RFC 0026 into the red lifecycle stage by adding #[ignore]d failing test stubs for each §5 scenario across the owning crates, and updates the RFC frontmatter status accordingly. It also updates RFC 0025’s §5 acceptance criteria text.

Changes:

• Flip RFC 0026 frontmatter status from specified → red.
• Add RFC 0026 red-gate #[ignore]d todo!() integration-test stubs in ourios-server and ourios-ingester.
• Replace RFC 0025’s §5 placeholder with concrete acceptance-criteria scenarios.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
docs/rfcs/0026-authentication-tenant-binding.md	Updates RFC 0026 lifecycle status to red.
docs/rfcs/0025-absent-body-representation.md	Writes concrete §5 acceptance criteria scenarios (replacing placeholder text).
crates/ourios-server/tests/rfc0026_auth.rs	Adds ignored red-gate stubs for RFC 0026 server-owned scenarios.
crates/ourios-ingester/tests/rfc0026_auth.rs	Adds ignored red-gate stubs for RFC 0026 ingest-owned scenarios.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.