Skip to content

test(bench): streaming corpus store builds + opt-in log4j severity #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensholdgaard merged 7 commits into from
Jul 4, 2026
Merged

test(bench): streaming corpus store builds + opt-in log4j severity #350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c590d4
test(bench): streaming corpus store builds + opt-in log4j severity
jensholdgaard Jul 4, 2026
d1b1dca
refactor(bench): move the corpus file list into the stream, no clone
jensholdgaard Jul 4, 2026
0c71c05
fix(bench): abort the streaming store build on the first write error
jensholdgaard Jul 4, 2026
147c2db
refactor(bench): borrow-generic streaming harness, no gate-path clone
jensholdgaard Jul 4, 2026
ebebbc5
style(bench): mark TxtSeverity non_exhaustive (BenchError convention)
jensholdgaard Jul 4, 2026
b03ce9e
docs(bench): align build_store/stream doc comments with the fallible …
jensholdgaard Jul 4, 2026
1ffe444
style(bench): hoist the severity-mode env read; document WARNING in t…
jensholdgaard Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/ourios-bench/benches/b1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ use std::path::Path;

use criterion::{BenchmarkId, Criterion, criterion_group, criterion_main};

use ourios_bench::{ReferenceCorpus, build_b1_store};
use ourios_bench::{ReferenceCorpus, TxtSeverity, build_b1_store};
use ourios_core::audit::ParamType;
use ourios_core::record::{BodyKind, MinedRecord, Param};
use ourios_core::tenant::TenantId;
Expand Down Expand Up @@ -245,7 +245,9 @@ fn real_corpus(c: &mut Criterion) {
continue;
}
let bucket = tempfile::TempDir::new().expect("temp bucket");
let built = build_b1_store(path, bucket.path(), ZSTD_LEVEL).expect("build b1 store");
let severity = TxtSeverity::from_env().expect("OURIOS_CORPUS_SEVERITY");
let built =
build_b1_store(path, bucket.path(), ZSTD_LEVEL, severity).expect("build b1 store");
Comment thread
jensholdgaard marked this conversation as resolved.
Resolved
let Some((severity, query)) = severity_query(&built, dir) else {
continue;
};
Expand Down
5 changes: 3 additions & 2 deletions crates/ourios-bench/benches/b2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use std::path::Path;

use criterion::{BenchmarkId, Criterion, criterion_group, criterion_main};

use ourios_bench::build_query_store;
use ourios_bench::{TxtSeverity, build_query_store};
use ourios_core::audit::ParamType;
use ourios_core::record::{BodyKind, MinedRecord, Param};
use ourios_core::tenant::TenantId;
Expand Down Expand Up @@ -192,7 +192,8 @@ fn real_corpus(c: &mut Criterion) {
continue;
}
let bucket = tempfile::TempDir::new().expect("temp bucket");
let built = build_query_store(path, bucket.path()).expect("build query store");
let severity = TxtSeverity::from_env().expect("OURIOS_CORPUS_SEVERITY");
let built = build_query_store(path, bucket.path(), severity).expect("build query store");
Comment thread
jensholdgaard marked this conversation as resolved.
Resolved
if built.busiest_template_rows == 0 {
eprintln!("b2/real-corpus: {dir} produced no rows — skipping");
continue;
Expand Down
Loading