Skip to content

docs(rfc-0009): flip compaction to validated (D2/D3/B2-post on baseline, §9.7) - #226

Merged
jensholdgaard merged 2 commits into
mainfrom
rfc0009-validated
Jun 15, 2026
Merged

docs(rfc-0009): flip compaction to validated (D2/D3/B2-post on baseline, §9.7)#226
jensholdgaard merged 2 commits into
mainfrom
rfc0009-validated

Conversation

@jensholdgaard

Copy link
Copy Markdown
Owner

What

Flips RFC 0009 (background compaction) green → validated and records the authoritative RFC0009.7 measurements in benchmarks.md §9.7. Docs-only — the bench code landed in #223/#224/#225.

Authoritative results — baseline-8vcpu-32gib, git 4d52288 (§9.7)

Provisioned a fresh ccx33, ran the ourios-bench compaction bench, captured, and tore the box down:

measure result verdict
D2 compaction throughput 485.2 MiB → 1 file in 2.91 s = 166.8 MiB/s, 153,600 rows conserved keeps up (single-partition, ≫ per-partition seal rate)
D3 small-file size band output 456.7 MiB — IN the 256 MiB–2 GiB band; 0% of live files < 128 MiB (target < 5%) PASS
B2-post query latency 32 row groups / 33.5 MB / 32 files → 1 / 1.05 MB / 1 file; 12.78 ms → 2.10 ms ≈ 6.1× PASS

D3 is the headline (the small-file problem eliminated — output squarely in the H4 band, zero sub-128 MiB). B2-post quantifies the query payoff that motivated RFC 0009 (PR #92: footer reads dominate). The structural reductions are hardware-independent and also pinned by rfc0009_1_* / compaction_conserves_every_row.

Honest scope note

The literal D2 sustained-ingest soak ("backlog returns to zero in a one-hour window at D1's rate") and D1 itself remain unrun — the 166.8 MiB/s is the RFC0009.7 compaction-throughput measure, recorded as such, not that soak. Tracked as a post-validated §7 follow-up.

Changes

  • benchmarks.md §9.7 — the authoritative D2/D3/B2-post entry (matches the §9.4/§9.6 format).
  • 0009-compaction.mdstatus: green → validated + status note updated.
  • roadmap.md — §3 row, "Last updated" stamp, and "what remains" updated.

mdbook builds clean.

Invariants

Docs-only; no code, no §3 invariant or §4 hazard touched. Records that hazard H4 (small-file problem) now has authoritative baseline evidence of compaction landing files in the target band.

🤖 Generated with Claude Code

@jensholdgaard
jensholdgaard requested a review from Copilot June 15, 2026 12:59
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jensholdgaard, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 3 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c8573be-8b8a-4802-bc85-4afce2791f1b

📥 Commits

Reviewing files that changed from the base of the PR and between 4d52288 and 1882474.

📒 Files selected for processing (3)
  • docs/benchmarks.md
  • docs/rfcs/0009-compaction.md
  • docs/roadmap.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rfc0009-validated

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Docs-only update to reflect RFC 0009 (background compaction) moving from green to validated, and to record the authoritative RFC0009.7 baseline measurements (D2/D3/B2-post) in the benchmarks log.

Changes:

  • Updated docs/rfcs/0009-compaction.md to status: validated and expanded the status note with the authoritative RFC0009.7 results and remaining follow-ups.
  • Added a new benchmarks.md §9.7 entry capturing the authoritative baseline host D2/D3/B2-post measurements for RFC 0009.
  • Updated docs/roadmap.md to reflect RFC 0009’s new status and adjust the “What remains” section accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
docs/roadmap.md Updates roadmap status row + “last updated” / “what remains” narrative to reflect RFC 0009 validated.
docs/rfcs/0009-compaction.md Flips RFC 0009 front-matter status to validated and documents the authoritative RFC0009.7 evidence + remaining follow-ups.
docs/benchmarks.md Adds §9.7 authoritative baseline results table and narrative for RFC 0009’s D2/D3/B2-post measures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/benchmarks.md Outdated
Comment thread docs/rfcs/0009-compaction.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@jensholdgaard
jensholdgaard merged commit 8b857c5 into main Jun 15, 2026
13 checks passed
@jensholdgaard
jensholdgaard deleted the rfc0009-validated branch June 15, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants