docs(rfc-0010): flip audit-stream/drift queries to green (§5 RFC0010.1-.8 pass) - #221
Conversation
|
Warning Review limit reached
More reviews will be available in 1 minute and 31 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Flips RFC 0010 (Audit-stream queries & template drift) from specified to green and updates the roadmap to reflect that the §5 acceptance criteria now pass (per existing test coverage in crates/ourios-querier/tests/drift.rs).
Changes:
- Update RFC 0010 frontmatter
statusand expand the status note with green-gate evidence and pointers to the acceptance tests. - Update
docs/roadmap.mdto reflect RFC 0010 asgreenand refresh the “Last updated” note accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/roadmap.md | Updates the RFC ladder entry + “Last updated” note to mark RFC 0010 as green. |
| docs/rfcs/0010-audit-stream-queries.md | Marks RFC 0010 as green and revises the status note to document evidence and the H5.3 relocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What
Flips RFC 0010 (Audit-stream queries & template drift)
specified → green. Pure docs change — all eight §5 acceptance scenarios were already implemented and tested on main (thedriftsurface landed in #165); the ladder label simply lagged.Evidence
All 8 scenarios pass in
crates/ourios-querier/tests/drift.rs(verified locally —cargo test -p ourios-querier --test drift: 10 passed):rfc0010_1_*[from, to)windowrfc0010_2_*event_typescoping excludes non-wideningsrfc0010_3_*rfc0010_4_*rfc0010_5_*rfc0010_6_*rfc0010_7_*rfc0010_8_*RFC0010.1 discharges RFC 0001 H5.3. The hazard test was relocated out of
ourios-miner/tests/hazards.rs(now a relocation pointer there) intoourios-querier/tests/drift.rs::h5_3_drift_query_returns_templates_that_gained_a_version— passing, no longer#[ignore]/todo!(). The status note's prior claim that the stub was still ignored was stale.Not gating green
§9's open questions are explicitly
accepted-gating, notgreen("none blockspecified"): the verb-head fork is resolved; the rest (range-clause vs stage, mandatory vs default window, tie-break stability, cross-kind version aggregation) are maintainer confirmations. General audit aggregation stays out of scope (§3.2).Invariants
Docs-only (RFC status note + roadmap §3 row/stamp). No code, no §3 invariant or §4 hazard touched — it records that hazard H5 (template drift detection) now has a first-class, tested query surface.
🤖 Generated with Claude Code