Skip to content

docs(rfc-0010): flip audit-stream/drift queries to green (§5 RFC0010.1-.8 pass) - #221

Merged
jensholdgaard merged 2 commits into
mainfrom
rfc0010-green
Jun 15, 2026
Merged

jensholdgaard merged 2 commits into
mainfrom
rfc0010-green

Conversation

@jensholdgaard

Copy link
Copy Markdown
Owner

What

Flips RFC 0010 (Audit-stream queries & template drift) specified → green. Pure docs change — all eight §5 acceptance scenarios were already implemented and tested on main (the drift surface landed in #165); the ladder label simply lagged.

Evidence

All 8 scenarios pass in crates/ourios-querier/tests/drift.rs (verified locally — cargo test -p ourios-querier --test drift: 10 passed):

Scenario Test
RFC0010.1 drift returns drifted templates w/ counts rfc0010_1_*
RFC0010.2 half-open [from, to) window rfc0010_2_*
RFC0010.3 event_type scoping excludes non-widenings rfc0010_3_*
RFC0010.4 tenant isolation rfc0010_4_*
RFC0010.5 empty-is-empty-not-error rfc0010_5_*
RFC0010.6 count-desc / id-asc ordering rfc0010_6_*
RFC0010.7 aggregate version/time bounds rfc0010_7_*
RFC0010.8 no DataFusion/SQL leakage rfc0010_8_*

RFC0010.1 discharges RFC 0001 H5.3. The hazard test was relocated out of ourios-miner/tests/hazards.rs (now a relocation pointer there) into ourios-querier/tests/drift.rs::h5_3_drift_query_returns_templates_that_gained_a_version — passing, no longer #[ignore]/todo!(). The status note's prior claim that the stub was still ignored was stale.

Not gating green

§9's open questions are explicitly accepted-gating, not green ("none block specified"): the verb-head fork is resolved; the rest (range-clause vs stage, mandatory vs default window, tie-break stability, cross-kind version aggregation) are maintainer confirmations. General audit aggregation stays out of scope (§3.2).

Invariants

Docs-only (RFC status note + roadmap §3 row/stamp). No code, no §3 invariant or §4 hazard touched — it records that hazard H5 (template drift detection) now has a first-class, tested query surface.

🤖 Generated with Claude Code

@jensholdgaard
jensholdgaard requested a review from Copilot June 15, 2026 09:05
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jensholdgaard, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 minute and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b5cf8255-5a71-4834-86ce-a55ce804cac2

📥 Commits

Reviewing files that changed from the base of the PR and between 06f46f1 and 1804c22.

📒 Files selected for processing (2)
  • docs/rfcs/0010-audit-stream-queries.md
  • docs/roadmap.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rfc0010-green

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Flips RFC 0010 (Audit-stream queries & template drift) from specified to green and updates the roadmap to reflect that the §5 acceptance criteria now pass (per existing test coverage in crates/ourios-querier/tests/drift.rs).

Changes:

  • Update RFC 0010 frontmatter status and expand the status note with green-gate evidence and pointers to the acceptance tests.
  • Update docs/roadmap.md to reflect RFC 0010 as green and refresh the “Last updated” note accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/roadmap.md Updates the RFC ladder entry + “Last updated” note to mark RFC 0010 as green.
docs/rfcs/0010-audit-stream-queries.md Marks RFC 0010 as green and revises the status note to document evidence and the H5.3 relocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/rfcs/0010-audit-stream-queries.md Outdated
Comment thread docs/roadmap.md Outdated
@jensholdgaard
jensholdgaard merged commit 88b3432 into main Jun 15, 2026
12 checks passed
@jensholdgaard
jensholdgaard deleted the rfc0010-green branch June 15, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants