docs(benchmarks): authoritative baseline thesis-gate results; rfc 0007 validated - #182
Conversation
…7 validated Records the baseline-8vcpu-32gib run (2026-06-11/12) as benchmarks.md $9.4: B1 34.2x/25.4x PASS, B2 flat incl. the first HDFS_v1 reading (11.2M rows, windowed 1/14 RGs at 5.92 ms) PASS, C1/C2 PASS, A1 FAIL with a new hardware-sensitivity caveat (open investigation item). Flips RFC 0007 to validated per the verification.md $3 ladder (the gates its pillar touches are B1/B2; A1 gates the compression pillar under RFC 0006) and resolves the validated-pending checklist. Updates $1/$3/$9 prose and the RFC 0006 cross-refs accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 30 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
Updates the documentation to record the newly-authorized “authoritative baseline” thesis-gate measurements and to advance RFC 0007 (querier/DataFusion) from green to validated in line with the verification ladder.
Changes:
- Add §9.4 “authoritative baseline” results to
docs/benchmarks.mdand update earlier B1/B2 narrative to reference the baseline run. - Flip
docs/rfcs/0007-querier.mdstatus tovalidatedand replace the prior status-note history with a condensed validation justification. - Update
docs/rfcs/0006-bench-harness.mdto reflect that B1/B2 are no longer “future” and are now measured/owned under RFC 0007.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/rfcs/0007-querier.md | Advances RFC 0007 to validated and documents why B1/B2 satisfy the validation ladder. |
| docs/rfcs/0006-bench-harness.md | Updates RFC 0006 text to reflect that B1/B2 are now implemented/measured via RFC 0007. |
| docs/benchmarks.md | Adds authoritative baseline results (§9.4) and updates B1/B2 sections to point at the authoritative measurements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…6 grammar Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Records the authoritative thesis-gate results from the dedicated
baseline-8vcpu-32gibhost (8 dedicated vCPU, 32 GiB, local NVMe-class SSD; runs 2026-06-11/12, no CI run id) asdocs/benchmarks.md§9.4, and flips RFC 0007 tovalidatedper the maintainer's 2026-06-12 authorization.Headline results (§9.4)
zstdcat | grepat 1 GiBWhy RFC 0007 flips to
validatedThe
docs/verification.md§3 ladder: "Validated. Every thesis-gate inbenchmarks.md§7 that the RFC's pillars touch passes on representative corpora." RFC 0007's pillar is the query engine (pillar #3 — DataFusion); the gates it touches are B1 and B2, both now passing on the §1 hardware baseline over ~1 GB+ corpora including a second corpus family (LogHub HDFS_v1, 11.2 M rows). A1's FAIL does not gate this RFC — A1 belongs to the template-mining/compression pillar, measured under RFC 0006, where its §7 escalation is handled. The prior validated-pending checklist resolves: baseline rerun ✓ (§9.4); second corpus family ✓ (HDFS_v1); denser error band — still open, recorded as a non-blocking quality improvement (B1 bands remain 11 / 28 rows).A1 hardware-sensitivity flag (recorded honestly in §9.4)
The authoritative A1 deltas sit below the
ci-runnerseries at every size (e.g. v5: ourios 23.8× on baseline vs 26.3× on CI, while zstd-19 stayed ~31.7× on both): the ourios writer's output is environment-sensitive — suspected row-group sizing / threading effects on the resulting encodings. Flagged as an open A1 investigation item alongside the structural gap.Scope & invariants
Doc-only (
docs/benchmarks.md,docs/rfcs/0006-bench-harness.mdcross-refs,docs/rfcs/0007-querier.mdstatus). No hot path touched; benchmark numbers are recorded, not produced, here. The hardware is identified only by thebaseline-8vcpu-32gibtag, per the §1 methodology note added in this PR. Every number was verified against the raw run logs.mdbook buildclean; new tables verified in the rendered HTML.🤖 Generated with Claude Code