Skip to content

docs(readme): reflect the implemented state + add status badges - #181

Merged
jensholdgaard merged 3 commits into
mainfrom
docs/readme-refresh
Jun 12, 2026
Merged

docs(readme): reflect the implemented state + add status badges#181
jensholdgaard merged 3 commits into
mainfrom
docs/readme-refresh

Conversation

@jensholdgaard

@jensholdgaard jensholdgaard commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Why

The README predates all code: it is untouched since the 2026-04-24 scaffolding and still opens with "Status: draft. No code exists yet", lists crates/ as "empty for now", advertises a speculative template:<id> / templates_drift(<service>) syntax and a "(LogQL-ish)" parser, and closes with "not, yet, a working backend". ~180 PRs have landed since. Maintainer-requested 2026-06-12.

What changed

  • Badge row (top): CI (ci.yml workflow badge), Apache-2.0 license, Rust stable / MSRV 1.85 (from rust-toolchain.toml + workspace rust-version), and an mdBook docs badge linking to the in-repo docs/SUMMARY.md (GitHub Pages is not enabled yet, so no Pages URL).
  • Status block: the IMPORTANT draft banner becomes an honest NOTE — pre-release, RFC-driven; ingest path (OTLP → WAL → miner → Parquet) and query path (DSL → DataFusion) implemented and tested; thesis being measured in docs/benchmarks.md; no packaged release.
  • Architecture diagram corrected: the old picture had miner → WAL → Arrow batches. The real pipeline (ourios-ingester::receiver::pipeline, §3.4 WAL-before-ack) is WAL (fsync, then ack) → miner → Parquet writer. The store is labelled local-FS today with object storage as the RFC 0005 design target, and the querier parser is "own grammar", not "LogQL-ish".
  • Two-features section now shows the shipped syntax: template_id == 42, resolves_to(42), and drift from -7d to now (RFC 0010), instead of the never-built template:<id> / templates_drift().
  • New "What is implemented" section keyed to RFCs 0001/0002/0003/0005/0007/0008/0009/0010, including the honest caveats (WAL checkpoint/truncation open; served querier role pending).
  • New "How it measures" section citing docs/benchmarks.md §9 as the live scoreboard, with the indicative ci-runner caveat stated up front: B1 30–40× vs zstdcat | grep with exact counts, B2 flat ~3–4 ms, C1 1.000000, and the A1 miss (~0.82× vs zstd-19 against a ≥ 3.0× gate) reported as a miss. Hardware is identified only by the ci-runner / baseline-8vcpu-32gib tags. Phrased to survive the in-progress authoritative baseline rerun.
  • Repo layout block updated to reality: 10 crates (incl. ourios-semconv, ourios-telemetry), semconv/ + templates/ weaver dirs, no deploy/ yet (Helm moved to "eventually" in Non-goals).
  • Documentation section now lists only files that exist; the previous list pointed at five docs/architecture/* files and a GOVERNANCE.md that were never created.

Invariants / hazards

Docs-only; no code paths touched. The diagram fix restores the §3.4 WAL-before-ack invariant in the project's front-door description (the old diagram showed the miner running before the WAL).

Verification

  • Every relative link in the new README checked to resolve against the repo tree.
  • RFC statuses read from frontmatter; pipeline order verified in crates/ourios-ingester/src/receiver/pipeline.rs; DSL syntax verified against RFC 0002/0010; benchmark numbers transcribed from docs/benchmarks.md §9.1–9.3.
  • README is not part of the mdBook (docs/SUMMARY.md does not include it), so no mdbook build impact.
  • One deliberate softening: RFC 0001's frontmatter still reads status: specified (the alias-amendment ladder re-entry; the alias scenarios have since landed in test(core): add the RFC 0001 alias write-path red gate (RFC0001.12-.16) #152/feat(core): operator-driven alias map + audited alias events (RFC0001.12-.16) #153 but the status flip hasn't), so the README describes the miner's implemented capabilities without asserting the RFC is green.

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated project status reflecting pre-release development phase
    • Revised architecture documentation and feature descriptions
  • Chores

    • Enhanced CI/CD pipeline with automated coverage badge publishing to main branch
    • Integrated OpenSSF Scorecard for security and quality analysis

The README was untouched since the 2026-04-24 scaffolding and still
claimed no code exists. ~180 PRs have landed since: the full ingest
path (OTLP receiver -> WAL -> miner -> Parquet), the query path
(pipe DSL -> DataFusion), and the first benchmark readings.

- add a four-badge row (CI, license, Rust/MSRV, mdBook docs)
- replace the draft banner with an honest pre-release status block
- fix the architecture diagram: WAL is fsync'd before the miner runs
  (WAL-before-ack), not after; Parquet store is local-FS today
- replace the speculative template:<id> / templates_drift() syntax
  with the shipped DSL (template_id ==, resolves_to(), drift from..to)
- add a What-is-implemented section keyed to the RFCs and a
  benchmarks section citing docs/benchmarks.md section 9 as the live
  scoreboard (indicative ci-runner numbers, A1 miss stated honestly)
- update repo layout (10 crates, semconv/ + templates/, no deploy/
  yet), drop dead doc links (GOVERNANCE.md, docs/architecture/* that
  never landed), point Documentation at files that exist

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jensholdgaard

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@jensholdgaard
jensholdgaard requested a review from Copilot June 11, 2026 23:32
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jensholdgaard, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d4bc39ce-baae-4af2-b570-ccaef17d6f5a

📥 Commits

Reviewing files that changed from the base of the PR and between 6e317e7 and a7da935.

📒 Files selected for processing (1)
  • README.md
📝 Walkthrough

Walkthrough

This pull request adds coverage badge publishing to a dedicated badges branch, introduces an OpenSSF Scorecard security analysis workflow, and substantially updates the README to reflect pre-release status, RFC-driven development gates, updated architecture diagrams, and expanded implementation checklists.

Changes

Project Visibility and Documentation

Layer / File(s) Summary
Coverage badge publishing
.github/workflows/ci.yml
The coverage job now grants contents: write permissions and adds a step that publishes coverage percentage as a coverage.json file to a badges branch on pushes to main, computing badge color from threshold ranges and managing state via GitHub APIs.
OpenSSF Scorecard integration
.github/workflows/scorecard.yml
New workflow runs OpenSSF Scorecard analysis on a weekly schedule, main branch pushes, and manual dispatch, with OIDC and SARIF upload permissions to publish results to code scanning.
Project status and feature documentation
README.md
Introduction and feature descriptions updated to reflect pre-release RFC-driven status, with refined language for Parquet predicate pushdown, template miner collapsing, template-exact queries with resolves_to(...) alias expansion, and drift querying.
Architecture and implementation documentation
README.md
Architecture diagram replaced with updated pipeline view (OTLP → WAL → template miner → Parquet writer + querier path), plus expanded "What is implemented" section with RFC-first checklist for all subsystems.
Operations, development, and governance guidance
README.md
Repository layout, performance messaging, documentation links, and governance sections updated with new directories (semconv/, templates/, testdata/) and consolidated pointers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • jensholdgaard/ourios#98: Both PRs modify .github/workflows/ci.yml and the non-gating coverage job; this PR additionally publishes a coverage badge to a separate branch.

Poem

🐰 A rabbit hops through workflows with glee,
Badges now published for all eyes to see—
Scorecards check health while docs paint the scene,
Visibility blooms in the pre-release sheen. 📊

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly summarizes the main change: updating the README to reflect the implemented state and adding status badges, which aligns with the substantial documentation updates and CI workflow additions.
Description check ✅ Passed The description provides detailed justification (Why), comprehensive change documentation (What changed), invariants/hazards, and verification steps. However, the required checklist template items (cargo fmt, clippy, tests, docs/CHANGELOG updates, RFC links) are not formally addressed in the structured template format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/readme-refresh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s top-level README to reflect the current implemented state of Ourios (rather than the original scaffold-era draft), including status, architecture, shipped DSL features, and pointers into the mdBook/RFC documentation set.

Changes:

  • Add status badges (CI, license, Rust/MSRV, mdBook docs).
  • Rewrite the status/feature/architecture sections to match the implemented ingest + query pipelines and current DSL surface.
  • Refresh repo layout + documentation links to match the current tree.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
…rkflow

Coverage job publishes a shields endpoint JSON to the badges branch on
main pushes (no external service); scorecard runs weekly + on main and
feeds the API badge + code scanning. Best Practices left as a
maintainer-enrollment placeholder.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jensholdgaard

Copy link
Copy Markdown
Owner Author

Extended per maintainer request: ecosystem-style live badges — self-hosted coverage endpoint (published by the coverage job to a badges branch on main pushes; no external service) + OpenSSF Scorecard workflow/badge. Best Practices + Codecov noted as maintainer-enrollment options in an HTML comment.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
README.md (1)

66-66: 💤 Low value

Consider rephrasing to avoid repetition of "exactly."

The word "exactly" appears twice in close proximity (lines 66 and 67 in the original context). This can be softened for better flow. For example, "This is what Parquet + DataFusion is already optimized for when the file layout is right."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 66, The sentence containing the phrase "This is exactly
what Parquet + DataFusion is" repeats "exactly" and should be rephrased for
better flow; replace that sentence (the one beginning "This is exactly what
Parquet + DataFusion is") with a softer wording such as "This is what Parquet +
DataFusion is already optimized for when the file layout is right." to remove
the repetition and improve readability.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@README.md`:
- Line 66: The sentence containing the phrase "This is exactly what Parquet +
DataFusion is" repeats "exactly" and should be rephrased for better flow;
replace that sentence (the one beginning "This is exactly what Parquet +
DataFusion is") with a softer wording such as "This is what Parquet + DataFusion
is already optimized for when the file layout is right." to remove the
repetition and improve readability.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e6bde42f-48fc-4282-960a-086d06b492f0

📥 Commits

Reviewing files that changed from the base of the PR and between 656986a and 6e317e7.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/scorecard.yml
  • README.md

…ays the contract

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jensholdgaard
jensholdgaard merged commit 42a7aa0 into main Jun 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants