-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused code #187
Remove unused code #187
Conversation
- Remove all code which was previously marked with `NotImplementedError("unused")`. - Remove unsued command line arguments
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 74.84% 77.45% +2.61%
==========================================
Files 25 25
Lines 4118 3952 -166
==========================================
- Hits 3082 3061 -21
+ Misses 1036 891 -145 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't have the bandwidth for a real review. I only had a very quick look at the changes and the coverage changes. The fact that code was removed that was not covered by tests is good. Overall I like the streamlining. Thanks for doing all the work!
Thanks for having a look and thanks for your support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Attention: This is rigorous cleanup! I removed code which appears to be broken, unused or unreachable within the code base. I cannot rule out that anything of that is used from external code, although I believe that it's very unlikely.
NotImplementedError("unused")