Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #187

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Remove unused code #187

merged 3 commits into from
Feb 19, 2024

Conversation

speleo3
Copy link
Collaborator

@speleo3 speleo3 commented Feb 2, 2024

Attention: This is rigorous cleanup! I removed code which appears to be broken, unused or unreachable within the code base. I cannot rule out that anything of that is used from external code, although I believe that it's very unlikely.

- Remove all code which was previously marked with
  `NotImplementedError("unused")`.
- Remove unsued command line arguments
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6ee0df8) 74.84% compared to head (25ed65e) 77.45%.

Files Patch % Lines
propka/lib.py 75.00% 1 Missing ⚠️
propka/parameters.py 96.66% 1 Missing ⚠️
propka/version.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   74.84%   77.45%   +2.61%     
==========================================
  Files          25       25              
  Lines        4118     3952     -166     
==========================================
- Hits         3082     3061      -21     
+ Misses       1036      891     -145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't have the bandwidth for a real review. I only had a very quick look at the changes and the coverage changes. The fact that code was removed that was not covered by tests is good. Overall I like the streamlining. Thanks for doing all the work!

@speleo3
Copy link
Collaborator Author

speleo3 commented Feb 4, 2024

Sorry, I don't have the bandwidth for a real review. I only had a very quick look at the changes and the coverage changes. The fact that code was removed that was not covered by tests is good. Overall I like the streamlining. Thanks for doing all the work!

Thanks for having a look and thanks for your support!

Copy link
Collaborator

@sobolevnrm sobolevnrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@speleo3 speleo3 merged commit 27e0ad2 into jensengroup:master Feb 19, 2024
13 checks passed
@speleo3 speleo3 deleted the remove-unused branch February 19, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove array-valued default arguments from methods Remove unused arguments from functions
3 participants