Remove unused components from node_details #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
merged commit f7d9b24
into
161754-infra-ui-replace-node-details-flyout-with-asset-details-flyout-in-the-inventory-page
1 of 2 checks passed
jennypavlova
added a commit
to elastic/kibana
that referenced
this pull request
Sep 28, 2023
…he inventory page (#166965) Closes #161754 Closes #166807 To make the testing and review easier I merged the old components [cleanup PR](jennypavlova#5) into this one ## Summary This PR replaces the old node details view with the asset details flyout ### Old  ### New  ### Testing 1. Go to inventory 2. Click on a host in the waffle map 3. Click on any **host** - These changes are related only if a `Host` is selected- in the case of a pod the view shouldn't be changed:  4. Check the new flyout functionality https://github.com/elastic/kibana/assets/14139027/3557821c-7964-466e-8514-84c2f81bc2fd Note: the selected host should have a border like in the previous version (this I fixed in the [last commit](ff4753a)) so it should be added if there is a selected node: <img width="1193" alt="image" src="https://github.com/elastic/kibana/assets/14139027/6646fe47-6333-435a-a5ec-248339402224"> --------- Co-authored-by: Kibana Machine <[email protected]>
jennypavlova
pushed a commit
that referenced
this pull request
Oct 14, 2024
…an-error-type-result-in-error-details-page-crashing [APM][Otel] Errors without an error type result in error details page crashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.