K8s nav dynamic & install integrations based on data #16
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,8 +16,10 @@ export interface ObservabilityNavigationServer { | |
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | ||
| export interface ObservabilityNavigationPluginSetup {} | ||
|
|
||
| export interface ObservabilityNavigationPluginStart { | ||
| core: CoreStart; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | ||
| export interface ObservabilityNavigationPluginSetupDependencies {} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { EuiLink } from '@elastic/eui'; | ||
| import type { ObservabilityOnboardingLocatorParams } from '@kbn/deeplinks-observability'; | ||
| import { OBSERVABILITY_ONBOARDING_LOCATOR } from '@kbn/deeplinks-observability'; | ||
| import { useKibana } from '@kbn/kibana-react-plugin/public'; | ||
| import type { SharePublicStart } from '@kbn/share-plugin/public/plugin'; | ||
| import { i18n } from '@kbn/i18n'; | ||
|
|
||
| const ADD_DATA_KUBERNETES_LABEL = i18n.translate('xpack.infra.metricsHeaderAddDataButtonLabel', { | ||
| defaultMessage: 'Add Kubernetes data', | ||
| }); | ||
|
|
||
| export const AddKubernetesDataLink = () => { | ||
| const { share } = useKibana<{ share: SharePublicStart }>().services; | ||
| const onboardingLocator = share?.url.locators.get<ObservabilityOnboardingLocatorParams>( | ||
| OBSERVABILITY_ONBOARDING_LOCATOR | ||
| ); | ||
|
|
||
| return ( | ||
| <EuiLink | ||
| data-test-subj="infraAddDataLink" | ||
| href={onboardingLocator?.getRedirectUrl({ | ||
| category: 'kubernetes', | ||
| })} | ||
| color="primary" | ||
| > | ||
| {ADD_DATA_KUBERNETES_LABEL} | ||
| </EuiLink> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,8 +12,12 @@ import type { DashboardApi, DashboardCreationOptions } from '@kbn/dashboard-plug | |
| import { KUBERNETES_DASHBOARD_LOCATOR_ID } from '@kbn/observability-shared-plugin/common'; | ||
| import type { SerializableRecord } from '@kbn/utility-types'; | ||
| import type { DashboardState } from '@kbn/dashboard-plugin/common'; | ||
| import { EuiLoadingSpinner } from '@elastic/eui'; | ||
| import { FETCH_STATUS } from '@kbn/observability-shared-plugin/public'; | ||
| import { useKibanaContextForPlugin } from '../../../../../hooks/use_kibana'; | ||
| import { useDatePickerContext } from '../../hooks/use_date_picker'; | ||
| import { AddKubernetesDataLink } from '../add_kubernetes_data/add_kubernetes_data'; | ||
| import { useFetchDashboardById } from '../../hooks/use_fetch_dashboard_by_id'; | ||
|
|
||
| export const RenderDashboard = ({ dashboardId }: { dashboardId: string }) => { | ||
| const { | ||
|
|
@@ -61,6 +65,15 @@ export const RenderDashboard = ({ dashboardId }: { dashboardId: string }) => { | |
| dashboard.setQuery({ query: '', language: 'kuery' }); | ||
| }, [dashboard, dashboardId, from, to]); | ||
|
|
||
| const { data: dashboardData, status } = useFetchDashboardById(dashboardId); | ||
|
|
||
| if (!dashboardData && status === FETCH_STATUS.LOADING) { | ||
| return <EuiLoadingSpinner size="xl" />; | ||
| } | ||
| if (!dashboardData && status !== FETCH_STATUS.LOADING && dashboardId.startsWith('kubernetes')) { | ||
| return <AddKubernetesDataLink />; | ||
| } | ||
|
|
||
| return ( | ||
| <DashboardRenderer | ||
| locator={locator} | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with Roshan, should we focus on otel and leave this and the toggle out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove them in the next PR and focus on OTel only (so all metricbeat logic here will be removed)