Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Java and fix running on recent Jenkins versions #55

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 22, 2024

Fixes https://issues.jenkins.io/browse/JENKINS-72701

Testing done

Submitter checklist

Preview Give feedback

@sue445 sue445 self-requested a review February 22, 2024 08:03
@orgads
Copy link
Contributor Author

orgads commented Feb 22, 2024

Looks like github is not that good with renames, even when put in a separate commit...

All the important changes are in 3d6ead4. Please review it.

@orgads orgads force-pushed the java branch 2 times, most recently from 4b2aac9 to 3d6ead4 Compare February 22, 2024 12:38
@orgads
Copy link
Contributor Author

orgads commented Feb 22, 2024

The heavy lifting was done with https://www.codeconvert.ai/groovy-to-java-converter. I tweaked it later to fix the build and tests.

Copy link
Contributor

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orgads Could you have all src/main/groovy/**/*.java files move to src/main/java/ ?

Other are LGTM

@orgads
Copy link
Contributor Author

orgads commented Feb 22, 2024

Done

@sue445 sue445 self-requested a review February 22, 2024 13:22
Copy link
Contributor

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sue445 sue445 merged commit 5986220 into jenkinsci:master Feb 22, 2024
12 checks passed
@orgads orgads deleted the java branch February 22, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants