-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Java and fix running on recent Jenkins versions #55
Conversation
Looks like github is not that good with renames, even when put in a separate commit... All the important changes are in 3d6ead4. Please review it. |
4b2aac9
to
3d6ead4
Compare
The heavy lifting was done with https://www.codeconvert.ai/groovy-to-java-converter. I tweaked it later to fix the build and tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orgads Could you have all src/main/groovy/**/*.java
files move to src/main/java/
?
Other are LGTM
No code changes yet.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
Fixes https://issues.jenkins.io/browse/JENKINS-72701
Testing done
Submitter checklist