-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #54
Conversation
+ Exclude expected issues for groovy files.
@orgads Thank you patch! I'II merge this after build is fixed 🙏 |
Where is the build configured? I think it should use java 11 instead of 1.8. |
@sue445 It looks like Jenkinsfile is used from master, I can't change it. https://ci.jenkins.io/job/Plugins/job/yaml-axis-plugin/job/PR-54/5/console
|
I launched the build with the revised Jenkinsfile from @orgads . Checks pass. Thanks for a very nice contribution! |
Great! Once you merge this PR, I'll rebase the other one (convert to Java) to ease its review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Testing done
Replaces #35, #45, #48, #49 and actually fixes the build.
Submitter checklist