Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #54

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Update dependencies #54

merged 4 commits into from
Feb 22, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 21, 2024

Testing done

Replaces #35, #45, #48, #49 and actually fixes the build.

Submitter checklist

Preview Give feedback

@sue445
Copy link
Contributor

sue445 commented Feb 22, 2024

@orgads Thank you patch! I'II merge this after build is fixed 🙏

@orgads
Copy link
Contributor Author

orgads commented Feb 22, 2024

Where is the build configured? I think it should use java 11 instead of 1.8.

@sue445
Copy link
Contributor

sue445 commented Feb 22, 2024

@orgads
Copy link
Contributor Author

orgads commented Feb 22, 2024

@sue445 It looks like Jenkinsfile is used from master, I can't change it.

https://ci.jenkins.io/job/Plugins/job/yaml-axis-plugin/job/PR-54/5/console

08:29:30  Loading trusted files from base branch master at 49b5fdf1f6395c5db9fc6d9ada7a6ecde404caa5 rather than 821fded7ade2aff11662b7e6da9a3793a693bfb0
08:29:30  Obtained Jenkinsfile from 49b5fdf1f6395c5db9fc6d9ada7a6ecde404caa5
08:29:31  ‘Jenkinsfile’ has been modified in an untrusted revision

@MarkEWaite
Copy link
Contributor

I launched the build with the revised Jenkinsfile from @orgads . Checks pass. Thanks for a very nice contribution!

@orgads
Copy link
Contributor Author

orgads commented Feb 22, 2024

Great! Once you merge this PR, I'll rebase the other one (convert to Java) to ease its review process.

Copy link
Contributor

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sue445 sue445 merged commit 00ebb0f into jenkinsci:master Feb 22, 2024
12 checks passed
@orgads orgads deleted the modernize branch February 22, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants