Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for lists as values in excludes mappings #20

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

raydouglass
Copy link
Contributor

Updates the excludes parsing so that values of the mappings can be either Strings or Lists. This allows for more concise and readable complex excludes. The original behavior (Map<String, String>) continues to work.

I updated the README.md and unit tests for the changes.

Examples (further details in readme changes):

# axis2.yml
exclude:
  - RUBY_VERSION: 2.1.8
  - RUBY_VERSION: 2.3.0
    DATABASE: 
      - oracle
      - mysql
# axis3.yml - cartesian product of both lists
exclude:
  - RUBY_VERSION: 
      - 2.1.8
      - 2.3.0
    DATABASE: 
      - oracle
      - mysql

@mike-wendt
Copy link

Super excited to see this as it simplifies our exclusion lists immensely. Thanks @raydouglass

@sue445 sue445 self-assigned this Nov 18, 2020
README.md Show resolved Hide resolved
Co-authored-by: GO Sueyoshi <[email protected]>
@sue445 sue445 merged commit ca25fe8 into jenkinsci:master Nov 20, 2020
@sue445
Copy link
Contributor

sue445 commented Nov 21, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants