This repository has been archived by the owner on Nov 7, 2020. It is now read-only.
pop unmarshalled type on exception #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Jan 19, 2018
| @@ -70,7 +70,6 @@ protected Object convert(Object parent, Class type, Converter converter) { | |||
| try { | |||
| types.push(type); | |||
There was a problem hiding this comment.
Best style to move this line outside the try block.
jglick
pushed a commit
to jglick/xstream-fork
that referenced
this pull request
Jan 19, 2018
jglick
pushed a commit
to jglick/xstream-fork
that referenced
this pull request
Jan 19, 2018
olivergondza
approved these changes
Jan 31, 2018
| @@ -80,6 +79,9 @@ protected Object convert(Object parent, Class type, Converter converter) { | |||
| addInformationTo(conversionException, type, converter, parent); | |||
| throw conversionException; | |||
| } | |||
| finally { | |||
There was a problem hiding this comment.
nit: should not be on a new line.
|
To be closed once jenkinsci/jenkins#4944 is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for the following scenario:
deserializing the following xml from jenkins:
(DescribableList)context.getRequiredType().newInstance()which tries tonew PerformancePublisher()