avoid printing too long argument in Pipeline Steps visualization #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
reviewed
Feb 1, 2019
| @@ -39,7 +40,7 @@ | |||
| @DataBoundConstructor public ArgumentsColumn() {} | |||
|
|
|||
| public String get(FlowNode node) { | |||
| return ArgumentsAction.getStepArgumentsAsString(node); | |||
| return StringUtils.substring(ArgumentsAction.getStepArgumentsAsString(node), 0, 80); | |||
There was a problem hiding this comment.
Maybe it would be better to truncate to 77, and if the text was truncated, add ... to make it clear that the content was truncated?
Please find attached screenshots. This is based on our production system but real strings were replaced. Before: After: |
In some cases it is possible that node argument will be impossible to wrap properly and is displayed as single line. In this case pipeline steps view becomes hard to read because right most columns are moved beyond the screen. This requires scrolling which is not so convenient. Also status colum is outside of screen. This change cuts arguments list to 80 characters which should be fine for most of usages. Signed-off-by: Artur Harasimiuk <[email protected]>
Signed-off-by: Artur Harasimiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it is possible that node argument will be impossible to
wrap properly and is displayed as single line. In this case pipeline
steps view becomes hard to read because right most columns are moved
beyond the screen. This requires scrolling which is not so convenient.
Also status colum is outside of screen.
This change cuts arguments list to 80 characters which should be fine
for most of usages.
Signed-off-by: Artur Harasimiuk [email protected]