Skip to content

Adding symbol to the WorkflowMultiBranchProject class descriptor #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2023

Conversation

joseblas
Copy link
Contributor

@joseblas joseblas commented Feb 7, 2023

The WorkflowMultiBranchProject class does not have a proper Symbol in the descriptor as many other such as FreeStyleProject (https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/FreeStyleProject.java#L79)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@joseblas joseblas marked this pull request as ready for review February 7, 2023 14:59
@joseblas joseblas requested a review from a team as a code owner February 7, 2023 14:59
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the display name currently specifies Pipeline

OTOH there is no other seriously maintained multibranch impl (literate plugin is long dead, as is yaml-project) so probably just multibranch is clear enough.

@jglick jglick merged commit 1090461 into jenkinsci:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants