Skip to content

EnvWorkflowTest#isNodeNameAvailable robustness #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Vlatombe
Copy link
Member

Despite Label.parse returning a TreeSet, Node#getAssignedLabels returns a Set and NODE_LABELS doesn't make any promise to return a sorted set.

So better match labels unordered.

Testing done

Submitter checklist

Preview Give feedback

Despite Label.parse returning a TreeSet, Node#getAssignedLabels returns a Set and NODE_LABELS doesn't make any promise to return a sorted set.

So better match labels unordered.
@car-roll car-roll added the tests label Aug 24, 2023
@MarkEWaite
Copy link
Contributor

Could this be labeled developer so that it will generate a new release of the plugin? Without the new release of the plugin, the plugin compatibility tests that are used in the plugin bill of materials will continue to fail as noted in jenkinsci/bom#2412

@jglick jglick added developer and removed tests labels Aug 24, 2023
@Vlatombe Vlatombe deleted the isNodeNameAvailable-robustness branch August 24, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants