build attribute for buildProgressBar should be a Queue.Executable, not a Queue.Task

[dwnusbaum]

See https://github.com/jenkinsci/jenkins/blob/4c5e4f86d1fb3bce5d027446e12259c7edcac27f/core/src/main/resources/lib/hudson/buildProgressBar.jelly#L29.

In practice this did not matter because the Jelly template only ever used build.url in this case, which is the same between PlaceholderTask and PlaceholderExecutable, but it causes problems with some changes I am proposing upstream in jenkinsci/jenkins#8321 where we actually need to find the associated Run, see this comment in particular.

Testing done

Tested manually.

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jglick]

https://issues.jenkins.io/browse/JENKINS-31203 sigh

[jglick]

Looks like it should work based on

workflow-durable-task-step-plugin/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java

Lines 1127 to 1130 in 94bdc2b

	@Restricted(NoExternalUse.class) // for Jelly and toString
	public String getUrl() {
	return PlaceholderTask.this.getUrl(); // we hope this has a console.jelly
	}

[dwnusbaum]

Turns out this does not work on its own; I am investigating.

[dwnusbaum]

A test failed on Windows, but I think it is unrelated:

Expected: is <ABORTED>
     but: was <SUCCESS>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.jvnet.hudson.test.JenkinsRule.assertBuildStatus(JenkinsRule.java:1450)
	at org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest.interruptingAbortsBuildEvenWithReturnStatus(ShellStepTest.java:728)

This message in the log is unexpected I think:

C:\Jenkins\agent\workspace\_durable-task-step-plugin_PR-330\target\tmp\j h9210212895039935246\workspace\p>ping -n 6 127.0.0.1  1>nul 
Body did not finish within grace period; terminating with extreme prejudice