Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not even try to use LogTaskListener #327

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Do not even try to use LogTaskListener #327

merged 2 commits into from
Jul 28, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 28, 2023

Likely pointless to even try to record sh step output when the build is so broken that TaskListener is not available from the StepContext! See jenkinsci/workflow-api-plugin#298.

@jglick jglick added the bug label Jul 28, 2023
@jglick jglick requested review from dwnusbaum, car-roll and a team July 28, 2023 22:26
@jglick jglick enabled auto-merge July 28, 2023 22:32
@jglick jglick merged commit 94bdc2b into jenkinsci:master Jul 28, 2023
@jglick jglick deleted the LogTaskListener branch August 17, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@car-roll car-roll car-roll approved these changes

@dwnusbaum dwnusbaum Awaiting requested review from dwnusbaum

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @car-roll