Implement SubTask.getOwnerExecutable
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jglick
commented
Jan 23, 2023
| @@ -429,6 +429,7 @@ public String getCookie() { | |||
| return j.getNode(label); | |||
| } | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
Not really related, just noticed while I was here.
| @@ -721,7 +736,7 @@ private String computeEnclosingLabel(FlowNode executorStepNode, List<FlowNode> h | |||
| } | |||
|
|
|||
| @Override public long getEstimatedDuration() { | |||
| Run<?,?> r = run(); | |||
| Run<?,?> r = runForDisplay(); | |||
There was a problem hiding this comment.
Also only tangentially related—there was no apparent reason not to be calling the newer and more robust runForDisplay in this context.
| @@ -613,6 +613,7 @@ private static void assertLogMatches(WorkflowRun build, String regexp) throws IO | |||
| Queue.Item[] items = Queue.getInstance().getItems(); | |||
| assertEquals(1, items.length); | |||
| assertEquals(p, items[0].task.getOwnerTask()); | |||
| assertEquals(b, items[0].task.getOwnerExecutable()); | |||
There was a problem hiding this comment.
Test is covering something unrelated, but seemed as good a place as any to cover the new method.
daniel-beck
reviewed
Jan 24, 2023
src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java
Outdated
Show resolved
Hide resolved
jglick
changed the title
SubTask.getOwnerExecutable
This was referenced Jan 24, 2023
car-roll
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the API introduced in jenkinsci/jenkins#7599, for now without requiring a newer core dep.