Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ShellStepTest.label with Hamcrest #253

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Improve ShellStepTest.label with Hamcrest #253

merged 1 commit into from
Jul 19, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 19, 2022

#250 (comment) now would fail like

Expected: an array containing a string containing "(some other text)"
     but: mismatches were: [was "Start of Pipeline", was "node", was "node block", was "isUnix", was "sh (Step with label)"]
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at org.jenkinsci.plugins.workflow.steps.durable_task.ShellStepTest.label(ShellStepTest.java:366)

@jglick jglick added the tests label Jul 19, 2022
@jglick jglick merged commit 9af20dd into jenkinsci:master Jul 19, 2022
@jglick jglick deleted the ShellStepTest.label branch July 19, 2022 20:16
@jglick jglick mentioned this pull request Jul 19, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@car-roll car-roll Awaiting requested review from car-roll

@basil basil Awaiting requested review from basil

@olamy olamy Awaiting requested review from olamy

@jtnord jtnord Awaiting requested review from jtnord

@raul-arabaolaza raul-arabaolaza Awaiting requested review from raul-arabaolaza

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @dwnusbaum