Demonstration that implementing getParentExecutable is necessary
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Nov 5, 2021
| main.setDefinition(new CpsFlowDefinition("node('" + s.getNodeName() + "') {writeBack()}", true)); | ||
| // Normal case: writing to our own build directory | ||
| WriteBackStep.controllerFile = new File(main.getBuildDir(), "1/stuff.txt"); | ||
| r.buildAndAssertSuccess(main); |
There was a problem hiding this comment.
Fails without getParentExecutable override.
| FreeStyleProject other = r.createFreeStyleProject("other"); | ||
| r.buildAndAssertSuccess(other); | ||
| WriteBackStep.controllerFile = new File(other.getBuildByNumber(1).getRootDir(), "hack"); | ||
| r.buildAndAssertSuccess(main); |
There was a problem hiding this comment.
Fails against older Jenkins versions without RunningBuildFilePathFilter.
(cherry picked from commit 45fe55f)
|
This is more |
|
makes sense. I just wanted some kind of indicator that the jenkins version was being bumped, but i can also just add that in the changelog as well |
jglick
added a commit
to jglick/workflow-durable-task-step-plugin
that referenced
this pull request
Dec 22, 2021
…ci/jenkins@f4e8497 backported this to 2.303.3 which we use as of jenkinsci#177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proves that #170 is necessary to retain compatibility with some rare use cases after jenkinsci/jenkins#5880: for example, Pipeline code coverage without jenkinsci/code-coverage-api-plugin#245 or jenkinsci/cobertura-plugin#130.