Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert back to 'useContainerAgent' for CI pipeline #174

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

dduportal
Copy link
Contributor

This PR is a tentative to study the behavior underlined in #173 / #172 (changing a pipeline library parameter that made a test unit to fail)

@dduportal dduportal marked this pull request as ready for review September 23, 2021 15:54
@dduportal
Copy link
Contributor Author

Hello @car-roll @timja , with the recent fixes done on ci.jenkins.io's configuration, it looks like that, finally, it works \o/

@timja
Copy link
Member

timja commented Sep 23, 2021

Hello @car-roll @timja , with the recent fixes done on ci.jenkins.io's configuration, it looks like that, finally, it works \o/

Pretty sure your change was ignored because you don't have write access, I've replayed the build here: https://ci.jenkins.io/job/Plugins/job/workflow-durable-task-step-plugin/job/PR-174/3/ , let's see how it goes

@timja
Copy link
Member

timja commented Sep 24, 2021

It passed after replay too so I guess fine now

@car-roll car-roll merged commit 65a4f98 into jenkinsci:master Sep 24, 2021
@dduportal dduportal deleted the chore/use-container-agent branch September 24, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants