Fix incrementals in PCT #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Sep 21, 2021
pom.xml
Outdated
| @@ -67,6 +67,7 @@ | |||
| <properties> | |||
| <revision>2.40</revision> | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <gitHubRepo>jenkinsci/workflow-durable-task-step-plugin</gitHubRepo> | |||
There was a problem hiding this comment.
or conventionally
Suggested change
| <gitHubRepo>jenkinsci/workflow-durable-task-step-plugin</gitHubRepo> | |
| <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> |
There was a problem hiding this comment.
true, although I just re-did the incremental tools command, so it should probably do that itself
Co-authored-by: Jesse Glick <[email protected]>
jglick
approved these changes
Sep 21, 2021
basil
reviewed
Sep 21, 2021
pom.xml
Outdated
| @@ -67,6 +67,7 @@ | |||
| <properties> | |||
| <revision>2.40</revision> | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | |||
There was a problem hiding this comment.
This already exists 5 lines down on line 74, added by me in commit 0f45901.
There was a problem hiding this comment.
So #165 introduced the property but did not use it; and this should just switch the scm section. Thanks for catching.
There was a problem hiding this comment.
thanks, I missed that, scm.connection was right at the top and when I saw it was wrong I just re-ran incremental tools over it to re-generate the config.
basil
approved these changes
Sep 21, 2021
jglick
approved these changes
Sep 21, 2021
car-roll
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in https://github.com/jenkinsci/bom/pull/640/checks?check_run_id=3626534874
cc @jglick @basil @car-roll