Rename PowershellScriptStep to WindowsPowerShellScriptStep #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from capitalization (PowerShell), the current branding used by Microsoft is "Windows PowerShell" for version 5.1 (and earlier, although those versions seem to be out of support) and just "PowerShell" for the multiplatform implementation (i.e. no more "Core"). I have not (yet) dropped the Core part, because it will still be in very common use.
dwnusbaum
requested changes
May 24, 2021
...main/java/org/jenkinsci/plugins/workflow/steps/durable_task/WindowsPowerShellScriptStep.java
Outdated
Show resolved
Hide resolved
But it does update more code/text places to refer to "Windows PowerShell".
|
@car-roll may as well include this in release? |
car-roll
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from capitalization (PowerShell), the current branding used by Microsoft is "Windows PowerShell" for version 5.1 (and earlier,
although those versions seem to be out of support) and just "PowerShell" for the multiplatform implementation (i.e. no more "Core").
I have not (yet) dropped the Core part from the other step class, because it is still in very common use (including in much of Microsoft's own materials).