ExecutorStepExecution.queue_task_cancelled should yield ABORTED not FAILURE #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schottsfired
approved these changes
Jan 7, 2021
…e-task-step-plugin into ExecutorStepExecution.queue_task_cancelled
…e-task-step-plugin into ExecutorStepExecution.queue_task_cancelled
|
Artifactory seems to be having difficulty today. |
car-roll
approved these changes
Nov 3, 2021
This was referenced Nov 15, 2021
Merged
jglick
added a commit
to jglick/kubernetes-plugin
that referenced
this pull request
Dec 7, 2021
jglick
added a commit
to jglick/kubernetes-plugin
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you click the red X next to a build under the master node, or in the build log, the build is marked
ABORTEDlike you would expect. But if you do the same on a heavyweight task on an executor, perhaps just because that is the most convenient place to find it, the build is markedFAILUREwhich seems inconsistent.