Skip to content

Migrate wiki #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 1, 2019
Merged

Migrate wiki #123

merged 11 commits into from
Nov 1, 2019

Conversation

car-roll
Copy link
Collaborator

Migrating CHANGELOG from wiki to github
adding README

@car-roll car-roll closed this Oct 25, 2019
@car-roll car-roll reopened this Oct 25, 2019
@car-roll car-roll mentioned this pull request Oct 28, 2019
@car-roll car-roll requested a review from dwnusbaum October 28, 2019 23:00
Copy link

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, non-blocking.

CHANGELOG.md Outdated
@@ -0,0 +1,390 @@
## Changelog

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to pull everything up a level?

Suggested change
## Changelog
# Changelog

CHANGELOG.md Outdated
@@ -0,0 +1,390 @@
## Changelog

### 2.34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 2.34
## 2.34

And so on...

CHANGELOG.md Outdated
## 2.35
2019 Nov 01

- Update durable-task (v1.33)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I wouldn't put this line in the changelog, since it doesn't really mean anything to users by itself, and a good portion of users are probably already running it anyway. IMO, the second line covers the change that users might care about in relation to the durable-task update.

CHANGELOG.md Outdated
2019 Nov 01

- Update durable-task (v1.33)
- Add `pwsh` step to support powershell name change ([JENKINS-48803](https://issues.jenkins-ci.org/browse/JENKINS-48803))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might reword like this:

Suggested change
- Add `pwsh` step to support powershell name change ([JENKINS-48803](https://issues.jenkins-ci.org/browse/JENKINS-48803))
- Add `pwsh` step, which works exactly like the existing `powershell` step, but runs `pwsh.exe` instead of `powershell.exe`, for use with PowerShell Core 6.0 and newer. ([JENKINS-48803](https://issues.jenkins-ci.org/browse/JENKINS-48803))

@car-roll car-roll merged commit b2e114a into jenkinsci:master Nov 1, 2019
@car-roll car-roll deleted the migrate-wiki branch November 1, 2019 16:30
Pipeline steps locking agents and workspaces, and running external processes that may survive a Jenkins restart or agent reconnection.


>**WARNING**: Older versions of this plugin may not be safe to use. Please review the following warnings before using an older version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed, the plugin site shows equivalent content in the sidebar to the right.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, see #124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants