Trivial code cleanup for tests #114
Conversation
| @@ -126,52 +114,6 @@ | |||
| }); | |||
| } | |||
|
|
|||
| /** Ephemeral and deleted when it disconnects */ | |||
| static class EphemeralDumbAgent extends Slave implements EphemeralNode { | |||
| // Ensure deleted | ||
| f1.delete(); | ||
| // Ensure file does not exist | ||
| assertFalse(Files.exists(f1)); |
There was a problem hiding this comment.
Did the old behavior matter if this plugin's test were being run in the same workspace more than once? I guess you could use Files.deleteIfExists(f1) to preserve the old behavior, but I'm not sure what the original concern was.
There was a problem hiding this comment.
I too was having a hard time understanding the original behavior. Your explanation is as good as any, so we might as well preserve the existing functionality. I switched to Files.deleteIfExists and updated the comment to reflect your explanation.
The Windows agent was broken, rebuilding. |
|
Another |
I think this should be good to go now. |
A series of trivial code cleanup changes for the tests in this repository. Most of these changes remove usages of deprecated functionality or otherwise fix IDE warnings. I kept each commit separate. Each commit message should be self-explanatory, but if anything is unclear I am happy to provide further explanation. Also, feel free to revert any specific cleanup commits that are unwanted.