Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description to be exposed in the Plugin Manager UI view #100

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 28, 2019

It shows The Jenkins Plugins Parent POM Project, see below:

image

Let's use the short description from https://plugins.jenkins.io/workflow-durable-task-step

It shows `The Jenkins Plugins Parent POM Project`, let's use the short description from https://plugins.jenkins.io/workflow-durable-task-step
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me, but I wonder if there was any reason this was not done previously? Looks like most Pipeline plugins are missing descriptions, for example workflow-cps and workflow-job.

If it wasn't an oversight, perhaps the reason is that workflow-aggregator has a description, and at the time the various plugins we have today were split from the aggregator the idea was that everyone would only interact with the aggregator plugin in the UI?

@v1v
Copy link
Member Author

v1v commented Mar 28, 2019

Indeed. I've found a bunch of plugins which don't have that particular description. So I took the lead to raise this PR rather than asking more widely in the mailing list. It sounds reasonable the reason for using the aggregator as the main interaction, but it's also awkward to skip the description by default. In both cases, I do not have any strong opinion. Let's see what others think about it.

Thanks @dwnusbaum

@dwnusbaum dwnusbaum merged commit 0707cd8 into jenkinsci:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants