Save build.xml during CpsFlowExecution.suspendAll
#923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did not in fact fix the problem. |
|
The immediate problem was #925, but even with that addressed, there seem to be random problems finding stored |
jglick
commented
Oct 13, 2024
Comment on lines
+1663
to
+1673
| if (cpsExec.owner != null) { | ||
| try { | ||
| Queue.Executable exec = cpsExec.owner.getExecutable(); | ||
| if (exec instanceof Saveable) { | ||
| LOGGER.fine(() -> "saving " + exec); | ||
| ((Saveable) exec).save(); | ||
| } | ||
| } catch (IOException x) { | ||
| LOGGER.log(Level.WARNING, "failed to save " + cpsExec, x); | ||
| } | ||
| } |
There was a problem hiding this comment.
or perhaps just
Suggested change
| if (cpsExec.owner != null) { | |
| try { | |
| Queue.Executable exec = cpsExec.owner.getExecutable(); | |
| if (exec instanceof Saveable) { | |
| LOGGER.fine(() -> "saving " + exec); | |
| ((Saveable) exec).save(); | |
| } | |
| } catch (IOException x) { | |
| LOGGER.log(Level.WARNING, "failed to save " + cpsExec, x); | |
| } | |
| } | |
| cpsExec.saveOwner(); |
though OTOH does
not already do just this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this will fix a hard-to-reproduce bug in
FlowHeaddeserialization. I have not managed to reproduce an error yet in a functional test, but I have found thatbuild.xmlincluding its list of heads is only getting saved rather incidentally from the asynchronous mode ofnotifyListeners, even thoughFlowNodes have gotten saved earlier andprogram.dathas been saved. If I insert some artificial delays intonotifyNewHeadand run a restart test involvingparallel, sometimesbuild.xmlis out of date after Jenkins shuts down, causing weird effects like the iota being off after restart, or block start nodes being omitted from the graph.