-
Notifications
You must be signed in to change notification settings - Fork 75
FlowExecutionList.Storage
#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -44,6 +44,8 @@ | |||
*/ | |||
public abstract class FlowExecutionOwner implements Serializable { | |||
|
|||
private static final long serialVersionUID = 1796027762257567194L; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently forgotten earlier. Even though this is abstract
and has no fields, and the sole implementation is WorkflowRun.Owner
which did specify an explicit serialVersionUID
, Java serialization requires that all superclasses running from the concrete implementation class up to the topmost class implementing Serializable
each have a stream class description including a compatible SVUID. Adding the getExternalizableId
method changes the computed SVUID for the superclass, despite obviously making no changes to the actual serial form, so the previous effective value must be restored.
(Noticed via a proprietary test which involved serializing a WorkflowRun.Owner
using a historical release of this plugin and then deserializing it in the current version. CC @gbhat618)
…ugin into FlowExecutionList-storage
@@ -99,6 +101,25 @@ public String getUrlOfExecution() throws IOException { | |||
return getUrl()+"execution/"; | |||
} | |||
|
|||
/** | |||
* The {@link Run#getExternalizableId}, if this owner is indeed a {@link Run}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Called by the CloudBees CI implementation. See jenkinsci/workflow-job-plugin#499.
Subsumes #368 & #369. Supersedes #312. Extension point used by CloudBees CI in HA mode to implement alternate behavior.