-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace handbuilt html with jelly for flow durability #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But tooltips on a drop down are really weird. So not sure if it's the worst idea to get rid of this.
Maybe it's place a help button below the dropdown you can hover over to get some more intel about the mode selected? Could be beneficial for less versed pipeline users.
Can’t see how that would look good, there’s already some help for the input itself which should answer most questions |
You can use |
Merge conflicts @timja. Do you have time to try #205 (comment)? If not, I guess this is OK as is. |
Works nicely, thanks for the tip @jglick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also just noticed that this whole thing should have been extending GlobalConfiguration
. Probably too late to change that compatibly, though.
The downside I can see with this is that tooltips are no longer shown.
But tooltips on a drop down are really weird. So not sure if it's the worst idea to get rid of this.
alternative to #202