Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace handbuilt html with jelly for flow durability #205

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

timja
Copy link
Member

@timja timja commented Mar 1, 2022

The downside I can see with this is that tooltips are no longer shown.

But tooltips on a drop down are really weird. So not sure if it's the worst idea to get rid of this.

alternative to #202

@timja timja mentioned this pull request Mar 1, 2022
6 tasks
@timja timja requested review from olamy and janfaracik March 1, 2022 09:05
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But tooltips on a drop down are really weird. So not sure if it's the worst idea to get rid of this.

Maybe it's place a help button below the dropdown you can hover over to get some more intel about the mode selected? Could be beneficial for less versed pipeline users.

@timja
Copy link
Member Author

timja commented Mar 2, 2022

But tooltips on a drop down are really weird. So not sure if it's the worst idea to get rid of this.

Maybe it's place a help button below the dropdown you can hover over to get some more intel about the mode selected? Could be beneficial for less versed pipeline users.

Can’t see how that would look good, there’s already some help for the input itself which should answer most questions

@jglick
Copy link
Member

jglick commented Apr 29, 2022

You can use FormValidation.ok (or .okWithHtml) to offer some descriptions of the current selection.

@jglick
Copy link
Member

jglick commented Jul 7, 2022

Merge conflicts @timja.

Do you have time to try #205 (comment)? If not, I guess this is OK as is.

@timja timja requested a review from jglick July 7, 2022 22:09
@timja
Copy link
Member Author

timja commented Jul 7, 2022

Works nicely, thanks for the tip @jglick

image

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also just noticed that this whole thing should have been extending GlobalConfiguration. Probably too late to change that compatibly, though.

@timja timja requested a review from jglick July 8, 2022 19:42
@jglick jglick merged commit 0016b4f into jenkinsci:master Jul 8, 2022
@timja timja deleted the replace-html-with-jelly branch July 8, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants