Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 9.4.11 upgrade #49

Merged
merged 5 commits into from
Jun 14, 2018
Merged

Jetty 9.4.11 upgrade #49

merged 5 commits into from
Jun 14, 2018

Conversation

olamy
Copy link
Member

@olamy olamy commented May 17, 2018

No description provided.

olamy added 3 commits May 17, 2018 11:28
Signed-off-by: olivier lamy <[email protected]>
Signed-off-by: olivier lamy <[email protected]>
Signed-off-by: olivier lamy <[email protected]>
if (in) {
baos.write( B64Code.decode( line));
try (ByteArrayOutputStream baos = new ByteArrayOutputStream())
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We commonly use Egyptian Brackets

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Codestyle changes need to be reverted, but the rest looks fine

Signed-off-by: olivier lamy <[email protected]>
@olamy olamy changed the title [WIP] Jetty 9.4.11 upgrade Jetty 9.4.11 upgrade Jun 12, 2018
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will land it as is. There are lost of refactorings to be done in this codebase anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants