Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to enable jetty jmx #47

Merged
merged 3 commits into from
May 5, 2018
Merged

add an option to enable jetty jmx #47

merged 3 commits into from
May 5, 2018

Conversation

olamy
Copy link
Member

@olamy olamy commented Mar 8, 2018

Signed-off-by: olivier lamy [email protected]

@olamy olamy requested a review from oleg-nenashev March 8, 2018 04:10
@oleg-nenashev
Copy link
Member

IIUC it adds JMX Jetty when CLI option is added. It would be nice for sure.

@olamy It would be great to have some user-facing documentation in README, e.g.:

  • CLI option documentation
  • A section, which describes Jetty JMX...
    • Links to official Jetty materials
    • Guides about configuring JMX in Winstone (IIUC it's not enough to use CLI option, Jetty config XMLs need to be updated)

If there are any related tickets in the bugtracker, it would be great to have them as well.

Do you also plan to modify Extras Executable WAR or Jenkins codebases to enable/pre-configure the feature in Jenkins? Or is it a patch for another project using Winstone? Both are fine.

@jenkinsci/code-reviewers FYI

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs documentation

@oleg-nenashev
Copy link
Member

@olamy Hi, any plans to finalize it soon? If no, I would propose to ship the current master branch state so that the new Jetty version gets adopted in weekly releases early

@oleg-nenashev oleg-nenashev self-assigned this Mar 27, 2018
@olamy
Copy link
Member Author

olamy commented Apr 30, 2018

@oleg-nenashev just adding a changelog entry and update documentation here https://wiki.jenkins.io/display/JENKINS/Starting+and+Accessing+Jenkins

Signed-off-by: olivier lamy <[email protected]>
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants