[JENKINS-73285] Set maximum parameter count to 10,000 to match the documentation #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
changed the title
MarkEWaite
approved these changes
Jun 26, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that the Winstone default is 10,000 (unlike the Jetty default of 1,000), but this statement is false, as Winstone only sets the value if the user specifies the option, and otherwise uses the Jetty default. Since Stapler forms are complex and often need thousands of parameters, this PR adjusts Winstone to match its own documentation and use a limit of 10,000.
Testing done
mvn clean verifypasses, including the new automated test added in Add automated test for JENKINS-73285 #393.Fixes jetty/jetty.project#11959