[JENKINS-23378] Jetty9 upgrade #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumped up the dependency to the latest Jetty9 and updated the rest of the code to catch up with the incompatible changes made between Jetty 8 to 9.
Jetty9 requiers Java7 whereas it used to be Java6, and AJP doesn't work. Given those changes, I think it warrants a major version number increment.
| <artifactId>spdy-jetty-http</artifactId> | ||
| <version>8.1.13.v20130916</version> | ||
| <artifactId>spdy-http-server</artifactId> | ||
| <version>9.2.15.v20160210</version> |
There was a problem hiding this comment.
Introduce a property for these so you need not repeat yourself.
|
👍 |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
I took a quick look at jetty-ajp code. While the code is relatively small, the relevant abstractions have so drastically changed in Jetty 9 that the porting is not practical unless one knows the architecture of Jetty deeply. So AJP support is not coming back. |
Merged
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of upgrading Jenkins to servlet 3.1, we need Winstone to support servlet 3.1, which this PR does by pulling in Jetty 9.2, which is the latest version of Jetty that runs on Java7.
Notable incompatibilities include:
This PR is to let others comment on the changes thus far, find those missing features from somewhere, and try it out on Jenkins. Once we decide to drop those functionalities, we need a follow-up change to clean up the help screen, really remove AJP related code, etc.