Update exe only if our version is newer

[nxtn]

Fixes winsw/winsw#399

• Our version is retrieved from project properties.
• Current version is queried from the Windows file version.
• Update exe only if our version is newer.

[nxtn]

@oleg-nenashev Could you offer me some suggestions to deal with the warnings by SpotBugs?

[oleg-nenashev]

Sorry, I missed that due to all other items on my plate. I will help to finish/integrate it as a part of the release for WinSW 2.7.0

[oleg-nenashev]

FTR

08:27:37  [INFO] --- spotbugs-maven-plugin:3.1.12.2:check (spotbugs) @ windows-slave-installer ---
08:27:37  [INFO] BugInstance size is 2
08:27:37  [INFO] Error size is 0
08:27:37  [INFO] Total bugs: 2
08:27:37  [ERROR] Should org.jenkinsci.modules.windows_slave_installer.SlaveExeUpdater$1$1.invoke(File, VirtualChannel) return a zero length array rather than null? [org.jenkinsci.modules.windows_slave_installer.SlaveExeUpdater$1$1, org.jenkinsci.modules.windows_slave_installer.SlaveExeUpdater$1$1, org.jenkinsci.modules.windows_slave_installer.SlaveExeUpdater$1$1] At SlaveExeUpdater.java:[line 84]At SlaveExeUpdater.java:[line 88]At SlaveExeUpdater.java:[line 92] PZLA_PREFER_ZERO_LENGTH_ARRAYS
08:27:37  [ERROR] Class org.jenkinsci.modules.windows_slave_installer.SlaveExeUpdater$1$1 defines non-transient non-serializable instance field this$1 [org.jenkinsci.modules.windows_slave_installer.SlaveExeUpdater$1$1] In SlaveExeUpdater.java SE_BAD_FIELD
08:27:37  [INFO] 

Both issues should be fixed by switching to a copy-on-write array. Also it might be preferable to just use the VersionNumber class from https://github.com/jenkinsci/lib-version-number . It should be already available to the module from the Jenkins Core classpath

[nxtn]

OK, OK, I got it.

This passes:

private static class Absolutize extends SlaveToMasterFileCallable<String> {
    private static final long serialVersionUID = 1L;
    public String invoke(File f, VirtualChannel channel) throws IOException {
        return f.getAbsolutePath();
    }
}

agentExe.act(new Absolutize());

This doesn't:

agentExe.act(new SlaveToMasterFileCallable<String>() {
    private static final long serialVersionUID = 1L;
    public String invoke(File f, VirtualChannel channel) throws IOException {
        return f.getAbsolutePath();
    }
});

Damn good.

[oleg-nenashev]

The code should do its job. Two implementation notes:

• There is a VersionNumber class which could help with version comparison

• It is possible to automate provisioning of the version through a filtered resource.

  • https://github.com/jenkinsci/jenkinsfile-runner/blob/master/bootstrap/pom.xml#L38-L54
  • https://github.com/jenkinsci/jenkinsfile-runner/blob/master/bootstrap/src/main/resources-filtered/jfr.properties
  • https://github.com/jenkinsci/jenkinsfile-runner/blob/d4143a979118edbafca135c3433a427554689c6d/bootstrap/src/main/java/io/jenkins/jenkinsfile/runner/bootstrap/Util.java#L48-L55

  Both can be done later, it is more important to actually ship the change

[nxtn]

• There is a VersionNumber class which could help with version comparison

It'd be better if there is a constructor that accepts integers rather than strings.

• It is possible to automate provisioning of the version through a filtered resource.

Will do.

[jglick]

@oleg-nenashev could you review & merge please? I would like to https://github.com/jenkinsci/jep/blob/master/jep/230/README.adoc#specification but I am blocked by the presence of nontrivial unmerged PRs.

[oleg-nenashev]

In my queue, sorry