Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 3 unnecessary stubbings in ChangesSinceLastBuildMacroTest.java #201

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

ARUS2023
Copy link
Contributor

Testing done

Submitter checklist

In our previous pull request #194, we forgot to remove 3 unnecessary stubbings in the method createBuild. We are submitting this pull request to remove those. Sorry we did not submit all of them at one.

private AbstractBuild createBuild2(Result result, int buildNumber, String message) {
AbstractBuild build = mock(AbstractBuild.class);
ChangeLogSet changes1 = createChangeLog2(message);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra whitespace here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out, we removed it.

@slide slide merged commit f704dc3 into jenkinsci:main Oct 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants