Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience method for more asset urls #28

Merged
merged 2 commits into from
Aug 22, 2020
Merged

Add convenience method for more asset urls #28

merged 2 commits into from
Aug 22, 2020

Conversation

timja
Copy link
Member

@timja timja commented Aug 22, 2020

Fixes #26

@timja timja requested a review from a team as a code owner August 22, 2020 06:58
@timja timja added the enhancement New feature or request label Aug 22, 2020
@timja timja requested a review from daniel-beck August 22, 2020 06:59
daniel-beck
daniel-beck approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion: Reduce code duplication: Use that method from getCssUrl() etc. to only have one Jenkins#getRootUrl call.

@timja timja merged commit 1b86708 into jenkinsci:master Aug 22, 2020
@timja timja deleted the to-asset-url branch August 22, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconvenient to add further CSS files
2 participants
@timja @daniel-beck