Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration to appearance page #210

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Conversation

timja
Copy link
Member

@timja timja commented Aug 21, 2023

Requires:
jenkinsci/jenkins#8403

Screenshots image

image

Testing done

Submitter checklist

Preview Give feedback

@timja timja added the enhancement New feature or request label Aug 24, 2023
@timja timja marked this pull request as ready for review September 10, 2023 21:21
@timja timja requested a review from a team as a code owner September 10, 2023 21:21
@timja timja enabled auto-merge (squash) September 10, 2023 21:21
@timja timja merged commit c1ff18d into jenkinsci:master Sep 10, 2023
@basil
Copy link
Member

basil commented Sep 11, 2023

[ERROR] io.jenkins.plugins.darktheme.jcasc.darksystem.DarkSystemThemeJcascTest -- Time elapsed: 23.65 s <<< FAILURE!
java.lang.AssertionError: Unexpected exception 
        at io.jenkins.plugins.casc.misc.JenkinsConfiguredWithCodeRule.before(JenkinsConfiguredWithCodeRule.java:50)
        at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:601)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: io.jenkins.plugins.casc.ConfiguratorException: unclassified: error configuring 'unclassified' with class io.jenkins.plugins.casc.impl.configurators.GlobalConfigurationCategoryConfigurator configurator
        at io.jenkins.plugins.casc.ConfigurationAsCode.invokeWith(ConfigurationAsCode.java:737)
        at io.jenkins.plugins.casc.ConfigurationAsCode.checkWith(ConfigurationAsCode.java:797)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:783)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:652)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configure(ConfigurationAsCode.java:621)
        at io.jenkins.plugins.casc.misc.JenkinsConfiguredWithCodeRule.before(JenkinsConfiguredWithCodeRule.java:47)
        ... 3 more
Caused by: io.jenkins.plugins.casc.ConfiguratorException: Invalid configuration elements for type class jenkins.model.GlobalConfigurationCategory$Unclassified : themeManager.
Available attributes : administrativeMonitorsConfiguration, ansiColorBuildWrapper, artifactManager, bitbucketEndpointConfiguration, buildDiscarders, builtInNode, casCGlobalConfig, customFolderIcon, defaultDisplayUrlProvider, defaultFolderConfiguration, defaultView, email-ext, envVarsFilter, fingerprints, gitHubConfiguration, gitHubPluginConfig, gitLabConnectionConfig, gitLabServers, globalConfigFiles, globalConfigurationImpl, globalDefaultFlowDurabilityLevel, globalLibraries, httpRequestGlobalConfig, jacoco, junitTestResultStorage, location, lockableResourcesManager, mailer, mavenModuleSet, metricsAccessKey, myView, nodeProperties, pipeline-model-docker, plugin, pollSCM, projectNamingStrategy, quietPeriod, rebuildDescriptor, resourceRoot, scmGit, scmRetryCount, shell, singleConditionalBuilder, slackNotifier, subversionSCM, throttleJobProperty, timestamper, upstream, usageStatistics, viewsTabBar
        at io.jenkins.plugins.casc.BaseConfigurator.handleUnknown(BaseConfigurator.java:387)
        at io.jenkins.plugins.casc.BaseConfigurator.configure(BaseConfigurator.java:374)
        at io.jenkins.plugins.casc.BaseConfigurator.check(BaseConfigurator.java:293)
        at io.jenkins.plugins.casc.ConfigurationAsCode.lambda$checkWith$9(ConfigurationAsCode.java:797)
        at io.jenkins.plugins.casc.ConfigurationAsCode.invokeWith(ConfigurationAsCode.java:731)
        ... 8 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants