Update content and spacing, add link to get more themes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Dec 1, 2022
| <j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:st="jelly:stapler" xmlns:th="/lib/theme-manager"> | ||
| <f:section title="${%Built-in Themes}"> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:l="/lib/layout" xmlns:th="/lib/theme-manager"> | ||
| <f:section title="${%Themes}"> |
There was a problem hiding this comment.
the reason this was called Built-in Themes was to stop the double themes label
You could probably fix that by making the radio label visually hidden or call it something like select a theme
There was a problem hiding this comment.
Done, changed it to 'Select theme' 👍
timja
approved these changes
Dec 1, 2022
|
Not sure what's going on with the build failure here |
|
I can't reproduce it with: same java and maven version |
|
Looks like https://bugs.openjdk.org/browse/JDK-8297889 fixed in 11.0.18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
What's changed
Would be good to get some thoughts - thanks :)