Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parent POM to 5.6 and Jenkins Baseline to 2.479 #127

Merged

Conversation

biru-codeastromer
Copy link
Contributor

@biru-codeastromer biru-codeastromer commented Feb 3, 2025

Description :

This PR updates key dependencies to improve compatibility, stability, and maintainability of the project:

-Updated Parent POM to the latest stable version 5.6, ensuring better dependency management and alignment with modern Jenkins plugin development standards.
-Upgraded Jenkins Baseline to 2.479

Testing done

-Successfully ran mvn clean verify -DskipTests to validate the build.

Screenshot 2025-02-03 at 11 32 00 AM

Submitter checklist

  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).

"No additional tests required as this PR only updates dependencies and does not introduce functional changes."

  • There is automated testing or an explanation that explains why this change has no tests.
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.

@biru-codeastromer biru-codeastromer requested a review from a team as a code owner February 3, 2025 06:00
@biru-codeastromer
Copy link
Contributor Author

May I know what might be cause of fails in ci checks , after updating parent POM to 5.6 I had to upgrade to Jenkins 2.452 as it was compatible but now the ci checks have failed 3 of them . I am investigating it. .

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. It needs to either use parent pom 4.88 and Jenkins baseline 2.452 or parent pom 5.6 and Jenkins baseline 2.479.

The plugin parent pom has been released with a new major version, 5.x. Plugin parent pom 4.x (currently through 4.88) supports Java 11, Java 17, and Java 21 using Spring Security 5, Java EE 8, and Eclipse Jetty 10. Plugin parent pom 5.x (currently through 5.6) supports Java 17 and Java 21 using Spring Security 6, Jakarta EE 9, and Eclipse Jetty 12. It requires a minimum Jenkins version of 2.479.1.

The major version transition from parent pom 4.x to parent pom 5.x includes the following upgrades:

  • Spring Security 5 to Spring Security 6
  • Java EE 8 to Jakarta EE 9
  • Eclipse Jetty 10 to Eclipse Jetty 12
  • Java 11 to Java 17 as minimum Java version

The Jenkins 2.479.1 changelog and upgrade guide describe the changes and the impact of those changes on users and on plugin developers.

The transition from plugin parent pom 4.x to 5.x requires changes in the pom file and usually requires changes in the plugin source code. Those changes include:

  • Plugin parent pom moves from 4.x to 5.x
  • Jenkins baseline moves to 2.479
  • Jenkins minimum version moves to 2.479.1
  • Plugin BOM moves to bom-2.479.x and should use the most recent release
  • Imports of javax.servlet switch to import jakarta.servlet (OpenRewrite can do this change)
  • StaplerRequest renamed to StaplerRequest2
  • StaplerResponse renamed to StaplerResponse2
  • Consumers from other plugins of any modified APIs (those using StaplerRequest or StaplerResponse) must be reviewed for compatibility or a compatibility layer must be created (not an issue for sonar quality gates plugin since there are no other plugins that depend on it)
  • (optionally) plugin source code is updated to use Java 17 language features (OpenRewrite does a very good job with that migration)

Examples of the transition are available from:

@biru-codeastromer
Copy link
Contributor Author

Thanks for your pull request. It needs to either use parent pom 4.88 and Jenkins baseline 2.452 or parent pom 5.6 and Jenkins baseline 2.479.

The plugin parent pom has been released with a new major version, 5.x. Plugin parent pom 4.x (currently through 4.88) supports Java 11, Java 17, and Java 21 using Spring Security 5, Java EE 8, and Eclipse Jetty 10. Plugin parent pom 5.x (currently through 5.6) supports Java 17 and Java 21 using Spring Security 6, Jakarta EE 9, and Eclipse Jetty 12. It requires a minimum Jenkins version of 2.479.1.

The major version transition from parent pom 4.x to parent pom 5.x includes the following upgrades:

  • Spring Security 5 to Spring Security 6
  • Java EE 8 to Jakarta EE 9
  • Eclipse Jetty 10 to Eclipse Jetty 12
  • Java 11 to Java 17 as minimum Java version

The Jenkins 2.479.1 changelog and upgrade guide describe the changes and the impact of those changes on users and on plugin developers.

The transition from plugin parent pom 4.x to 5.x requires changes in the pom file and usually requires changes in the plugin source code. Those changes include:

  • Plugin parent pom moves from 4.x to 5.x
  • Jenkins baseline moves to 2.479
  • Jenkins minimum version moves to 2.479.1
  • Plugin BOM moves to bom-2.479.x and should use the most recent release
  • Imports of javax.servlet switch to import jakarta.servlet (OpenRewrite can do this change)
  • StaplerRequest renamed to StaplerRequest2
  • StaplerResponse renamed to StaplerResponse2
  • Consumers from other plugins of any modified APIs (those using StaplerRequest or StaplerResponse) must be reviewed for compatibility or a compatibility layer must be created (not an issue for sonar quality gates plugin since there are no other plugins that depend on it)
  • (optionally) plugin source code is updated to use Java 17 language features (OpenRewrite does a very good job with that migration)

Examples of the transition are available from:

Thanks a lot Sir for your detailed response regarding this . Much appreciated .

I will be implementing the changes now .

@mPokornyETM
Copy link
Contributor

@jonesbusy #127
FYI:Ö that means, you can write this plugin new. ;-)
A lot of time ago, I tryied to update this plugin with Jenkins components, tada-tables ... . After spending few hours into reading the code, I has stopped it. Most of the code is done in javaScript, use very old jquery libraries, use source files from not known sources (json3-min.js) .... .

this shall be not a comment to de-motivate you. You are of cores welcome to improv ethis plugin. Maybe I will find some time to help you.

thx a lot

@biru-codeastromer
Copy link
Contributor Author

Thanks for your pull request. It needs to either use parent pom 4.88 and Jenkins baseline 2.452 or parent pom 5.6 and Jenkins baseline 2.479.

The plugin parent pom has been released with a new major version, 5.x. Plugin parent pom 4.x (currently through 4.88) supports Java 11, Java 17, and Java 21 using Spring Security 5, Java EE 8, and Eclipse Jetty 10. Plugin parent pom 5.x (currently through 5.6) supports Java 17 and Java 21 using Spring Security 6, Jakarta EE 9, and Eclipse Jetty 12. It requires a minimum Jenkins version of 2.479.1.

The major version transition from parent pom 4.x to parent pom 5.x includes the following upgrades:

  • Spring Security 5 to Spring Security 6
  • Java EE 8 to Jakarta EE 9
  • Eclipse Jetty 10 to Eclipse Jetty 12
  • Java 11 to Java 17 as minimum Java version

The Jenkins 2.479.1 changelog and upgrade guide describe the changes and the impact of those changes on users and on plugin developers.

The transition from plugin parent pom 4.x to 5.x requires changes in the pom file and usually requires changes in the plugin source code. Those changes include:

  • Plugin parent pom moves from 4.x to 5.x
  • Jenkins baseline moves to 2.479
  • Jenkins minimum version moves to 2.479.1
  • Plugin BOM moves to bom-2.479.x and should use the most recent release
  • Imports of javax.servlet switch to import jakarta.servlet (OpenRewrite can do this change)
  • StaplerRequest renamed to StaplerRequest2
  • StaplerResponse renamed to StaplerResponse2
  • Consumers from other plugins of any modified APIs (those using StaplerRequest or StaplerResponse) must be reviewed for compatibility or a compatibility layer must be created (not an issue for sonar quality gates plugin since there are no other plugins that depend on it)
  • (optionally) plugin source code is updated to use Java 17 language features (OpenRewrite does a very good job with that migration)

Examples of the transition are available from:

Thanks for the Help Sir , I did made the required changes and has changed it accordingly !

@biru-codeastromer
Copy link
Contributor Author

I ran 'mvn clean verify` successfully after implemently the suggestions .

birajitsaikia@Birajits-MacBook-Pro test-results-analyzer-plugin % mvn clean verify  
[INFO] Scanning for projects...
[INFO] Artifact org.jenkins-ci.tools:maven-hpi-plugin:pom:3.60 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [incrementals (https://repo.jenkins-ci.org/incrementals/, default, releases), central (https://repo.maven.apache.org/maven2, default, releases)]
[INFO] Artifact org.jenkins-ci.tools:maven-hpi-plugin:pom:3.60 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [incrementals (https://repo.jenkins-ci.org/incrementals/, default, releases), central (https://repo.maven.apache.org/maven2, default, releases)]
[WARNING] The POM for org.jenkins-ci.tools:maven-hpi-plugin:jar:3.60 is missing, no dependency information available
[INFO] Artifact org.jenkins-ci.tools:maven-hpi-plugin:jar:3.60 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [incrementals (https://repo.jenkins-ci.org/incrementals/, default, releases), central (https://repo.maven.apache.org/maven2, default, releases)]
[INFO] Artifact org.jenkins-ci.tools:maven-hpi-plugin:jar:3.60 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [incrementals (https://repo.jenkins-ci.org/incrementals/, default, releases), central (https://repo.maven.apache.org/maven2, default, releases)]
[WARNING] Failed to build parent project for org.jenkins-ci.plugins:test-results-analyzer:hpi:0.4.2-SNAPSHOT
[INFO] 
[INFO] ------------< org.jenkins-ci.plugins:test-results-analyzer >------------
[INFO] Building Test Results Analyzer Plugin 0.4.2-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ hpi ]---------------------------------
[INFO] 
[INFO] --- clean:3.4.0:clean (default-clean) @ test-results-analyzer ---
[INFO] Deleting /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target
[INFO] 
[INFO] --- hpi:3.60:validate (default-validate) @ test-results-analyzer ---
[INFO] Created marker file /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/java-level/17
[INFO] 
[INFO] --- hpi:3.60:validate-hpi (default-validate-hpi) @ test-results-analyzer ---
[INFO] 
[INFO] --- enforcer:3.5.0:enforce (display-info) @ test-results-analyzer ---
[INFO] Rule 0: io.jenkins.tools.incrementals.enforcer.RequireExtensionVersion passed
[INFO] Rule 1: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed
[INFO] Rule 2: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed
[INFO] Rule 3: org.codehaus.mojo.extraenforcer.dependencies.EnforceBytecodeVersion passed
[INFO] Rule 4: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO] Rule 5: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO] Rule 6: org.apache.maven.enforcer.rules.dependency.RequireUpperBoundDeps passed
[INFO] 
[INFO] --- enforcer:3.5.0:enforce (no-snapshots-in-release) @ test-results-analyzer ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.dependency.RequireReleaseDeps passed
[INFO] 
[INFO] --- localizer:1.31:generate (default) @ test-results-analyzer ---
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ test-results-analyzer ---
[INFO] Copying 7 resources from src/main/resources to target/classes
[INFO] 
[INFO] --- flatten:1.6.0:flatten (flatten) @ test-results-analyzer ---
[INFO] Generating flattened POM of project org.jenkins-ci.plugins:test-results-analyzer:hpi:0.4.2-SNAPSHOT...
[INFO] 
[INFO] --- compiler:3.13.0:compile (default-compile) @ test-results-analyzer ---
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 15 source files with javac [debug parameters release 17] to target/classes
[INFO] org.jenkinsci.plugins.testresultsanalyzer.TestResultsAnalyzerExtension indexed under hudson.Extension
[INFO] org.jenkinsci.plugins.testresultsanalyzer.TestResultsAnalyzerExtension.DESCRIPTOR indexed under hudson.Extension
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/config/UserConfig.java:[14,12] Generating org/jenkinsci/plugins/testresultsanalyzer/config/UserConfig.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[239,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckPassedRepresentation.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[243,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckFailedRepresentation.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[274,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckPassedColor.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[286,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckNaColor.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[251,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckNaRepresentation.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[247,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckSkippedRepresentation.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[278,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckFailedColor.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[231,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckNoOfRunsToFetch.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[235,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckNoOfBuilds.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java:[282,31] Generating org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/DescriptorImpl/doCheckSkippedColor.stapler
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerAction.java: /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerAction.java uses or overrides a deprecated API.
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerAction.java: Recompile with -Xlint:deprecation for details.
[INFO] 
[INFO] --- access-modifier-checker:1.34:enforce (default-enforce) @ test-results-analyzer ---
[INFO] 
[INFO] --- hpi:3.60:insert-test (default-insert-test) @ test-results-analyzer ---
[INFO] 
[INFO] --- antrun:3.1.0:run (createTempDir) @ test-results-analyzer ---
[INFO] Executing tasks
[INFO]     [mkdir] Created dir: /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/tmp
[INFO] Executed tasks
[INFO] 
[INFO] --- resources:3.3.1:testResources (default-testResources) @ test-results-analyzer ---
[INFO] skip non existing resourceDirectory /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/test/resources
[INFO] 
[INFO] --- compiler:3.13.0:testCompile (default-testCompile) @ test-results-analyzer ---
[INFO] Recompiling the module because of changed dependency.
[INFO] Compiling 9 source files with javac [debug parameters release 17] to target/test-classes
[INFO] /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/src/test/java/FakeTabulatedResult.java:[9,8] Generating FakeTabulatedResult.javadoc
[INFO] 
[INFO] --- hpi:3.60:test-hpl (default-test-hpl) @ test-results-analyzer ---
[INFO] Generating /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-classes/the.hpl
[INFO] 
[INFO] --- hpi:3.60:resolve-test-dependencies (default-resolve-test-dependencies) @ test-results-analyzer ---
[INFO] 
[INFO] --- hpi:3.60:test-runtime (default-test-runtime) @ test-results-analyzer ---
[INFO] Setting jenkins.addOpens to --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED
[INFO] Setting jenkins.insaneHook to --patch-module='java.base=/Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/patch-modules/org-netbeans-insane-hook.jar' --add-exports=java.base/org.netbeans.insane.hook=ALL-UNNAMED
[INFO] 
[INFO] --- surefire:3.5.2:test (default-test) @ test-results-analyzer ---
[INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
Running tests for org.jenkins-ci.plugins:test-results-analyzer:0.4.2-SNAPSHOT
[INFO] Running JsTreeUtilTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 s -- in JsTreeUtilTest
[INFO] Running org.jenkins_ci.plugins.test_results_analyzer.InjectedTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.156 s -- in org.jenkins_ci.plugins.test_results_analyzer.InjectedTest
[INFO] Running org.jenkinsci.plugins.testresultanalyzer.AnalyzerPageTest
[WARNING] Tests run: 11, Failures: 0, Errors: 0, Skipped: 11, Time elapsed: 0.001 s -- in org.jenkinsci.plugins.testresultanalyzer.AnalyzerPageTest
[INFO] Running org.jenkinsci.plugins.testresultsanalyzer.ResultStatusTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 s -- in org.jenkinsci.plugins.testresultsanalyzer.ResultStatusTest
[INFO] 
[INFO] Results:
[INFO] 
[WARNING] Tests run: 23, Failures: 0, Errors: 0, Skipped: 11
[INFO] 
[INFO] 
[INFO] --- license:165.v7e11f4e4a_325:process (default) @ test-results-analyzer ---
[INFO] Generated /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer/WEB-INF/licenses.xml
[INFO] 
[INFO] --- hpi:3.60:hpi (default-hpi) @ test-results-analyzer ---
[INFO] Generating /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer/META-INF/MANIFEST.MF
[INFO] Checking for attached .jar artifact ...
[INFO] Generating jar /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer.jar
[INFO] Building jar: /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer.jar
[INFO] Exploding webapp...
[INFO] Copy webapp webResources to /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer
[INFO] Assembling webapp test-results-analyzer in /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer
[INFO] Generating hpi /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer.hpi
[INFO] Building jar: /Users/birajitsaikia/Documents/pomxml/test-results-analyzer-plugin/target/test-results-analyzer.hpi
[INFO] 
[INFO] --- jar:3.4.2:test-jar (maybe-test-jar) @ test-results-analyzer ---
[INFO] Skipping packaging of the test-jar
[INFO] 
[INFO] >>> spotbugs:4.8.3.1:check (spotbugs) > :spotbugs @ test-results-analyzer >>>
[INFO] 
[INFO] --- spotbugs:4.8.3.1:spotbugs (spotbugs) @ test-results-analyzer ---
[INFO] Fork Value is true
[INFO] Done SpotBugs Analysis....
[INFO] 
[INFO] <<< spotbugs:4.8.3.1:check (spotbugs) < :spotbugs @ test-results-analyzer <<<
[INFO] 
[INFO] 
[INFO] --- spotbugs:4.8.3.1:check (spotbugs) @ test-results-analyzer ---
[INFO] BugInstance size is 0
[INFO] Error size is 0
[INFO] No errors/warnings found
[INFO] 
[INFO] --- spotless:2.44.2:check (default) @ test-results-analyzer ---
[INFO] Index file does not exist. Fallback to an empty index
[INFO] Spotless.Java is keeping 23 files clean - 0 needs changes to be clean, 23 were already clean, 0 were skipped because caching determined they were already clean
[INFO] Sorting file /var/folders/5n/z0kr1gg10c7f4s00tcj9grqm0000gn/T/pom13375915477894966585.xml
[INFO] Pom file is already sorted, exiting
[INFO] Spotless.Pom is keeping 1 files clean - 0 needs changes to be clean, 1 were already clean, 0 were skipped because caching determined they were already clean
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  11.986 s
[INFO] Finished at: 2025-02-03T18:27:19+05:30
[INFO] ------------------------------------------------------------------------

@biru-codeastromer
Copy link
Contributor Author

biru-codeastromer commented Feb 3, 2025

Also brought back the comments that were present in original codebase .
Also mentioned some comment from my side too .

CI checks have passed successfully now . Thanks

Please let me know for further improvements if needed .

@MarkEWaite MarkEWaite changed the title Update Parent POM to 5.6 and Jenkins Baseline to 2.452 Update Parent POM to 5.6 and Jenkins Baseline to 2.479 Feb 3, 2025
@biru-codeastromer
Copy link
Contributor Author

biru-codeastromer commented Feb 4, 2025

I have removed the extra comment that I wrote as it was not previously present and was not needed too .

@biru-codeastromer
Copy link
Contributor Author

It was interesting when I removed a comment and push I got one ci check failed in security scan . Now I revived it back therefore .

@mPokornyETM
Copy link
Contributor

It was interesting when I removed a comment and push I got one ci check failed in security scan . Now I revived it back therefore .

I does nto check it, But I am pretty sure, that your commit has nothing to do with security. We have currently "only" 22
{813421F2-AC7E-48FF-9196-D00FE40CC2AA} security issues in the master branch. You can ignore it. LGTM

Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@biru-codeastromer
Copy link
Contributor Author

LGTM

Thanks!

@biru-codeastromer
Copy link
Contributor Author

Thanks for your pull request.

Hi Sir, if there are any additional improvements or further changes required, please let me know—I’d be more than happy to incorporate them. Your insights are greatly appreciated, and I’m eager to ensure this PR meets all the necessary standards.

Thank you once again for your time and support!

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally use the most recent release of the plugin BOM

Co-authored-by: Mark Waite <[email protected]>
@biru-codeastromer
Copy link
Contributor Author

Optionally use the most recent release of the plugin BOM

Done Sir . Thanks for the suggestion !

@MarkEWaite MarkEWaite merged commit 7c6b0cc into jenkinsci:master Feb 5, 2025
17 checks passed
@biru-codeastromer biru-codeastromer deleted the update-parent-pom-5.6 branch February 6, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants