Fix library class equality across template and steps #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
fixes #279.
Resolves a bug involving class equivalency between steps and the template.
Description
While you could import a library class everywhere, it was actually a different version of that class due to disparate classloaders being used.
This PR resolves that by leveraging a common classloader across the pipeline template and each library step.
this also changes the initialization order of JTE.
Previously, it was:
CpsFlowExecution
it is now:
CpsFlowExecution
CpsFlowExecution
This change has no impact on end-users but allows JTE to pass the actual
CpsFlowExecution
toTemplatePrimitiveInjectors
.How Has This Been Tested
Tests added that reproduce failure.
Tests pass now.
Types of Changes
Checklist