[JENKINS-73929] Handle custom buildsDir #588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Oct 15, 2024
src/main/java/com/cloudbees/jenkins/support/impl/RunDirectoryComponent.java
Outdated
Show resolved
Hide resolved
| @@ -97,6 +91,26 @@ public boolean understandsSymlink() { | |||
| } | |||
| } | |||
|
|
|||
| private static String getBuildRelativePath(@NonNull Run item, @NonNull File itemRootDir) { | |||
|
|
|||
| // See Jenkins#isDefaultBuildDir that has restriction and cannot be used outside Jenkins core | |||
There was a problem hiding this comment.
I think it is Jenkins.getBuildDirFor you want to look at. What if Jenkins.buildsDir is set to, e.g., ${ITEM_ROOTDIR}/all-the-builds?
Co-authored-by: Jesse Glick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case buildsDir is customize, relativize against the buildsDir root directory to calculate the prefix.
Testing done
Tested with / without custom
buildsDirTested with Multibranch branch job builds and standalone pipeline job builds
Submitter checklist