Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-65097] Add information about websocket in nodes.md #271

Merged
merged 1 commit into from
Apr 8, 2021
Merged

[JENKINS-65097] Add information about websocket in nodes.md #271

merged 1 commit into from
Apr 8, 2021

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Mar 12, 2021 •
edited
Loading

JENKINS-65097: Add a field to Nodes with JNLPLauncher, whether they use Websocket or no. This requires to update the Core dependency to 2.222 (see jenkinsci/jenkins@5b50402)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh Dohbedoh requested review from MRamonLeon and aheritier April 7, 2021 02:23
@Dohbedoh Dohbedoh merged commit ddc50b6 into jenkinsci:master Apr 8, 2021
@Dohbedoh Dohbedoh deleted the JENKINS-65097 branch December 29, 2022 05:51
@jglick jglick mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRamonLeon MRamonLeon MRamonLeon approved these changes

@aheritier aheritier Awaiting requested review from aheritier

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dohbedoh @MRamonLeon