Migrate from com.google.common.base.Predicate to java.util.function.Predicate #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the fact that
com.google.common.base.Predicateis used in public APIs, it is safe to migrate this tojava.util.function.Predicate.Searching for API usages in sources
The only references in sources are to a copy of Stapler in the
io.jenkins.blueocean.commons.stapler.exportpackage namespace, apparently added in jenkinsci/blueocean-plugin#711. These references are to a different package and we are not affecting them in this change.FilteringTreePrunerHAS_PROPERTY_NAMEHAS_PROPERTY_NAME_IN_ANCESTRYSearching for API usages in binaries
Creating
/tmp/additionalClasseswithand
/tmp/additionalFieldswiththen using
jenkins-infra/usage-in-pluginsto look for usages in plugins, including those in CloudBees CI, withmvn process-classes exec:exec -Dexec.executable=java -Dexec.args='-classpath %classpath org.jenkinsci.deprecatedusage.Main --additionalClasses /tmp/additionalClasses --additionalFields /tmp/additionalFields --onlyIncludeSpecified --updateCenter https://jenkins-updates.cloudbees.com/update-center/envelope-core-oc/update-center.json?version=2.263.2.3,https://jenkins-updates.cloudbees.com/update-center/envelope-core-mm/update-center.json?version=2.263.2.3'produced no references.