Fixing use of Timeout
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a @cloudbees CI run of |
jglick
commented
Dec 19, 2023
| @@ -46,11 +46,15 @@ public class AgentConnectionBase { | |||
| @ClassRule | |||
| public static CheckIsDockerAvailable isDockerAvailable = new CheckIsDockerAvailable(); | |||
|
|
|||
| @Rule | |||
| @Rule(order = 10) | |||
There was a problem hiding this comment.
Previously, the 3m default timeout in JenkinsRule superseded the expressed timeout here.
| public JenkinsRule j = new JenkinsRule(); | ||
|
|
||
| @Rule | ||
| public Timeout globalTimeout= new Timeout(4, TimeUnit.MINUTES); | ||
| @Rule(order = -10) |
There was a problem hiding this comment.
Default order is -1 so this seems to make it apply to @Rule GenericContainer in subclasses.
| public Timeout globalTimeout = Timeout.builder().withTimeout(10, TimeUnit.MINUTES).withLookingForStuckThread(true).build(); | ||
|
|
||
| protected AgentConnectionBase() { | ||
| j.timeout = 0; |
kuisathaverat
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still trying to fix timeouts occurring in CI from this plugin.
shows the first test,
AgentCurve25519Sha256ConnectionTest, taking >4m (topshows somedocker, a lot ofdpkg). Subsequent tests mostly run in <10s, so layer caching is effective.